Conor425/ludusavi-manifest
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix handling of page moves in recent changes when no redirect is left and there are no edits since the move

Browse source
This commit is contained in:
mtkennerly 2020-08-04 16:42:12 -04:00
parent eec7d58e6e
commit 18eb5e91d7
7 changed files with 566 additions and 402 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/manifest.ts
View file

@ -132,10 +132,15 @@ export class ManifestFile extends YamlFile<Manifest> {
}
}
const game = await getGame(title, wikiCache);
delete wikiCache[title].recentlyChanged;
if (game.files === undefined && game.registry === undefined && game.steam?.id === undefined) {
const [verifiedTitle, game] = await getGame(title, wikiCache);
delete wikiCache[verifiedTitle].recentlyChanged;
if (verifiedTitle !== title) {
delete this.data[title];
}
if (game.files === undefined && game.registry === undefined && game.steam?.id === undefined) {
delete this.data[verifiedTitle];
continue;
}
if (game.steam?.id !== undefined) {
@ -147,7 +152,7 @@ export class ManifestFile extends YamlFile<Manifest> {
game.installDir[installDir] = {}
}
}
this.data[title] = game;
this.data[verifiedTitle] = game;
await new Promise(resolve => setTimeout(resolve, DELAY_BETWEEN_GAMES_MS));
}

35
src/wiki.ts
View file

@ -479,10 +479,39 @@ export async function getRecentChanges(newest: Date, oldest: Date): Promise<Rece
/**
* https://www.pcgamingwiki.com/wiki/Template:Game_data
*/
export async function getGame(pageTitle: string, cache: WikiGameCache): Promise<Game> {
export async function getGame(pageTitle: string, cache: WikiGameCache): Promise<[string, Game]> {
console.log(pageTitle);
const wiki = makeApiClient();
const page = await wiki.page(pageTitle, { rvprop: "ids|content" });
let page = await wiki.page(pageTitle, { rvprop: "ids|content" });
if (page.missing !== undefined) {
// Couldn't find it by name, so try again by ID.
// This can happen for pages moved without leaving a redirect.
// (If they have a redirect, then the recent changes code takes care of it.)
const pageId = cache[pageTitle].pageId;
const client = makeApiClient2();
const params = {
action: "query",
pageids: [pageId],
};
try {
const [data, _] = await callMw<{ pages: { [id: string]: { title: string } } }>(
client.api, "call", params
);
const newTitle = data.pages[pageId.toString()].title;
console.log(`:: getGame: page ${pageId} called '${pageTitle}' renamed to '${newTitle}'`);
cache[newTitle] = cache[pageTitle];
delete cache[pageTitle];
if (cache[newTitle].renamedFrom === undefined) {
cache[newTitle].renamedFrom = [pageTitle];
} else {
cache[newTitle].renamedFrom.push(pageTitle);
}
page = await wiki.page(newTitle, { rvprop: "ids|content" });
pageTitle = newTitle;
} catch {
console.log(`:: page ${pageId} called '${pageTitle}' no longer exists`);
}
}
const game: Game = {
files: {},
@ -637,5 +666,5 @@ export async function getGame(pageTitle: string, cache: WikiGameCache): Promise<
}
cache[pageTitle].revId = page.revisions?.[0]?.revid ?? 0;
return game;
return [pageTitle, game];
}