From 9d0d0d243568a97136c5a144e76abc8a91382709 Mon Sep 17 00:00:00 2001 From: mtkennerly Date: Fri, 19 Jul 2024 16:14:58 -0400 Subject: [PATCH] Add workaround for Nine Sols registry size issue --- data/manifest-override.yaml | 6 ++++++ data/manifest.yaml | 4 ---- src/manifest.rs | 5 +++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/data/manifest-override.yaml b/data/manifest-override.yaml index 2e727986..adfd01b2 100644 --- a/data/manifest-override.yaml +++ b/data/manifest-override.yaml @@ -17,6 +17,12 @@ Nevsky Run: # Also, it's been renamed on Steam to "Secret Girl" # and is no longer available for sale. useSteamCloud: false +Nine Sols: + # The registry.yaml backups can become large (> 100 MB), + # causing memory usage in Ludusavi to spike (> 1 GB). + # For now, we ignore the registry until there is a proper solution. + # https://github.com/mtkennerly/ludusavi/issues/370 + omitRegistry: true Overwatch: # The game is no longer playable at all, # and its save locations are identical to Overwatch 2, diff --git a/data/manifest.yaml b/data/manifest.yaml index 10bbfb9d..751d6d56 100644 --- a/data/manifest.yaml +++ b/data/manifest.yaml @@ -436730,10 +436730,6 @@ Nine Sols: - when: - os: windows store: steam - registry: - HKEY_CURRENT_USER/SOFTWARE/RedCandleGames/NineSols: - tags: - - config steam: id: 1809540 "Nine Witches: Family Disruption": diff --git a/src/manifest.rs b/src/manifest.rs index 2f29cd2e..d389a3e0 100644 --- a/src/manifest.rs +++ b/src/manifest.rs @@ -455,6 +455,10 @@ impl Game { self.id.flatpak = Some(flatpak.clone()); } self.install_dir.extend(overridden.game.install_dir.clone()); + + if overridden.omit_registry { + self.registry.clear(); + } } pub fn usable(&self) -> bool { @@ -620,6 +624,7 @@ pub struct ManifestOverride(pub BTreeMap); #[serde(default, rename_all = "camelCase")] pub struct OverrideGame { pub omit: bool, + pub omit_registry: bool, pub use_steam_cloud: bool, #[serde(flatten)] pub game: Game,