mirror of
https://github.com/servo/servo.git
synced 2025-08-29 17:18:23 +01:00
Auto merge of #25644 - pshaughn:windowreflecting, r=jdm
Give error and resize special getter/setters for body/frameset reflection <!-- Please describe your changes on the following line: --> Most of the event handlers that needed to be reflected between body and window were doing so via special getter/setters in htmlelement.rs, but error and resize were missing; they are now included, passing the tests for whether these are reflected. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25186 for the case that isn't a bad test or an unimplemented event type, and fix #25187 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
commit
004f0cfcbf
5 changed files with 60 additions and 75 deletions
|
@ -1,14 +1,9 @@
|
|||
[event-handler-attributes-body-window.html]
|
||||
type: testharness
|
||||
[error]
|
||||
expected: FAIL
|
||||
|
||||
[HTMLBodyElement event handlers]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed error (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed auxclick (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -27,9 +22,6 @@
|
|||
[not shadowed paste (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed error (document.createElement("body"))]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed auxclick (document.createElement("body"))]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -48,27 +40,15 @@
|
|||
[not shadowed paste (document.createElement("body"))]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed resize (window)]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed loadend (window)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed resize (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed resize (document.createElement("body"))]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed securitypolicyviolation (window)]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed auxclick (window)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed error (window)]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed slotchange (window)]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -113,4 +93,3 @@
|
|||
|
||||
[not shadowed webkitanimationstart (window)]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
@ -1,19 +1,7 @@
|
|||
[event-handler-attributes-frameset-window.html]
|
||||
[shadowed resize (window)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed error (document.createElement("frameset"))]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed paste (document.createElement("frameset"))]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed resize (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed resize (document.createElement("frameset"))]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed securitypolicyviolation (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -44,9 +32,6 @@
|
|||
[not shadowed paste (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed error (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed copy (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -56,9 +41,6 @@
|
|||
[not shadowed cut (document.createElement("frameset"))]
|
||||
expected: FAIL
|
||||
|
||||
[shadowed error (window)]
|
||||
expected: FAIL
|
||||
|
||||
[not shadowed auxclick (document.createElement("frameset"))]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -106,4 +88,3 @@
|
|||
|
||||
[not shadowed webkitanimationiteration (document.body)]
|
||||
expected: FAIL
|
||||
|
||||
|
|
|
@ -2,9 +2,6 @@
|
|||
[event-handler-attributes-windowless-body]
|
||||
expected: FAIL
|
||||
|
||||
[Ignore setting of error window event handlers on windowless body]
|
||||
expected: FAIL
|
||||
|
||||
[auxclick is unaffected on a windowless body]
|
||||
expected: FAIL
|
||||
|
||||
|
@ -14,9 +11,6 @@
|
|||
[securitypolicyviolation is unaffected on a windowless body]
|
||||
expected: FAIL
|
||||
|
||||
[Ignore setting of error window event handlers on windowless frameset]
|
||||
expected: FAIL
|
||||
|
||||
[auxclick is unaffected on a windowless frameset]
|
||||
expected: FAIL
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue