Enable CSS Tables by default (#31470)

And remove the pref `layout.tables.enabled`.
This commit is contained in:
Oriol Brufau 2024-03-07 11:09:10 +01:00 committed by GitHub
parent d076b118c4
commit 007a31c1b5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
525 changed files with 488 additions and 802 deletions

View file

@ -519,9 +519,6 @@ mod gen {
enabled: bool,
},
legacy_layout: bool,
tables: {
enabled: bool,
},
#[serde(default = "default_layout_threads")]
threads: i64,
writing_mode: {

View file

@ -3,7 +3,6 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use app_units::Au;
use servo_config::pref;
use style::computed_values::mix_blend_mode::T as ComputedMixBlendMode;
use style::computed_values::position::T as ComputedPosition;
use style::computed_values::transform_style::T as ComputedTransformStyle;
@ -580,13 +579,12 @@ impl From<stylo::Display> for Display {
let outside = match outside {
stylo::DisplayOutside::Block => DisplayOutside::Block,
stylo::DisplayOutside::Inline => DisplayOutside::Inline,
stylo::DisplayOutside::TableCaption if pref!(layout.tables.enabled) => {
stylo::DisplayOutside::TableCaption => {
return Display::GeneratingBox(DisplayGeneratingBox::LayoutInternal(
DisplayLayoutInternal::TableCaption,
));
},
stylo::DisplayOutside::TableCaption => DisplayOutside::Block,
stylo::DisplayOutside::InternalTable if pref!(layout.tables.enabled) => {
stylo::DisplayOutside::InternalTable => {
let internal = match inside {
stylo::DisplayInside::TableRowGroup => DisplayLayoutInternal::TableRowGroup,
stylo::DisplayInside::TableColumn => DisplayLayoutInternal::TableColumn,
@ -605,7 +603,6 @@ impl From<stylo::Display> for Display {
};
return Display::GeneratingBox(DisplayGeneratingBox::LayoutInternal(internal));
},
stylo::DisplayOutside::InternalTable => DisplayOutside::Block,
// This should not be a value of DisplayInside, but oh well
// special-case display: contents because we still want it to work despite the early return
stylo::DisplayOutside::None if inside == stylo::DisplayInside::Contents => {
@ -627,17 +624,14 @@ impl From<stylo::Display> for Display {
stylo::DisplayInside::None => return Display::None,
stylo::DisplayInside::Contents => return Display::Contents,
stylo::DisplayInside::Table if pref!(layout.tables.enabled) => DisplayInside::Table,
stylo::DisplayInside::Table |
stylo::DisplayInside::Table => DisplayInside::Table,
stylo::DisplayInside::TableRowGroup |
stylo::DisplayInside::TableColumn |
stylo::DisplayInside::TableColumnGroup |
stylo::DisplayInside::TableHeaderGroup |
stylo::DisplayInside::TableFooterGroup |
stylo::DisplayInside::TableRow |
stylo::DisplayInside::TableCell => DisplayInside::Flow {
is_list_item: packed.is_list_item(),
},
stylo::DisplayInside::TableCell => unreachable!("Internal DisplayInside found"),
};
Display::GeneratingBox(DisplayGeneratingBox::OutsideInside { outside, inside })
}

View file

@ -101,7 +101,6 @@
"layout.columns.enabled": false,
"layout.flexbox.enabled": false,
"layout.legacy_layout": false,
"layout.tables.enabled": false,
"layout.threads": 3,
"layout.writing-mode.enabled": false,
"media.glvideo.enabled": false,

View file

@ -0,0 +1,2 @@
[table-caption-is-containing-block-001.html]
expected: FAIL

View file

@ -0,0 +1,2 @@
[table-caption-passes-abspos-up-001.html]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-048.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-055.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-060.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-078.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-081.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-090.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-093.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-096.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-104.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-106.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-111.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-114.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-117.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-120.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-128.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-130.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-135.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-138.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-141.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-144.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-152.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-154.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-184.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-188.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-190.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-194.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-196.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-001.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-002.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-003.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-004.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-005.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-007.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-013.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-applies-to-014.xht]
expected: FAIL

View file

@ -0,0 +1,2 @@
[background-applies-to-015.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-001.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-002.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-003.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-004.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-005.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-007.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-013.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-color-applies-to-014.xht]
expected: FAIL

View file

@ -0,0 +1,2 @@
[background-color-applies-to-015.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-001.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-002.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-003.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-004.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-005.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-007.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-013.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-image-applies-to-014.xht]
expected: FAIL

View file

@ -0,0 +1,2 @@
[background-image-applies-to-015.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-001.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-001a.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-001b.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-001c.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-001d.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-001e.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-002.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-002a.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-002b.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-002c.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-002d.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-002e.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-003.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-003b.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-003c.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-003d.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-003e.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-004.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-005.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-005a.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-005b.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-005c.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-005d.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-005e.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-006b.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-006c.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-006d.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-006e.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-007.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-013.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-013d.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-013e.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-position-applies-to-014.xht]
expected: FAIL

View file

@ -0,0 +1,2 @@
[background-position-applies-to-015.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-001.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-002.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-003.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-004.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-005.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-013.xht]
expected: FAIL

View file

@ -1,2 +0,0 @@
[background-repeat-applies-to-014.xht]
expected: FAIL

Some files were not shown because too many files have changed in this diff Show more