From 10f849fc5ba34e4807e54a799edd9630ff5b0613 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Mon, 27 Jun 2016 17:58:55 +0200 Subject: [PATCH 1/3] Update js. --- components/servo/Cargo.lock | 3 +-- ports/cef/Cargo.lock | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/components/servo/Cargo.lock b/components/servo/Cargo.lock index 3567185edac..5b6714c211b 100644 --- a/components/servo/Cargo.lock +++ b/components/servo/Cargo.lock @@ -1067,7 +1067,7 @@ dependencies = [ [[package]] name = "js" version = "0.1.3" -source = "git+https://github.com/servo/rust-mozjs#28f9fb0625a798ad53abf7edeb3e8b7bc0007dc3" +source = "git+https://github.com/servo/rust-mozjs#707bfb4ff4fe2c0abde1cc2bb87ac35ff8f40aaa" dependencies = [ "heapsize 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", "lazy_static 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)", @@ -1075,7 +1075,6 @@ dependencies = [ "log 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", "mozjs_sys 0.0.0 (git+https://github.com/servo/mozjs)", "num-traits 0.1.32 (registry+https://github.com/rust-lang/crates.io-index)", - "rustc-serialize 0.3.19 (registry+https://github.com/rust-lang/crates.io-index)", ] [[package]] diff --git a/ports/cef/Cargo.lock b/ports/cef/Cargo.lock index 4e903d6a003..0e6d35e4c66 100644 --- a/ports/cef/Cargo.lock +++ b/ports/cef/Cargo.lock @@ -976,7 +976,7 @@ dependencies = [ [[package]] name = "js" version = "0.1.3" -source = "git+https://github.com/servo/rust-mozjs#28f9fb0625a798ad53abf7edeb3e8b7bc0007dc3" +source = "git+https://github.com/servo/rust-mozjs#707bfb4ff4fe2c0abde1cc2bb87ac35ff8f40aaa" dependencies = [ "heapsize 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", "lazy_static 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)", @@ -984,7 +984,6 @@ dependencies = [ "log 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)", "mozjs_sys 0.0.0 (git+https://github.com/servo/mozjs)", "num-traits 0.1.32 (registry+https://github.com/rust-lang/crates.io-index)", - "rustc-serialize 0.3.19 (registry+https://github.com/rust-lang/crates.io-index)", ] [[package]] From 300f2df2034ad97ababf7e161691f72ee90c4e54 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Mon, 27 Jun 2016 13:31:28 +0200 Subject: [PATCH 2/3] Remove a useless local variable. --- components/script/dom/bindings/codegen/CodegenRust.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index b5b5b9f2b9b..3fec78bebb2 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -4753,9 +4753,7 @@ class CGDOMJSProxyHandler_hasOwn(CGAbstractExternMethod): return indexed + """\ let expando = RootedObject::new(cx, get_expando_object(proxy)); if !expando.ptr.is_null() { - let mut b = true; - let ok = JS_HasPropertyById(cx, expando.handle(), id, &mut b); - *bp = b; + let ok = JS_HasPropertyById(cx, expando.handle(), id, bp); if !ok || *bp { return ok; } From 296afe4bc9b8cf1a45f26ded51dd632a058862d2 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Mon, 27 Jun 2016 15:06:13 +0200 Subject: [PATCH 3/3] Use ObjectOpResult::succeed. --- components/script/dom/bindings/codegen/CodegenRust.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index 3fec78bebb2..76aab6b9b53 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -4574,8 +4574,7 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod): "unforgeables. Figure out how that should work!") set += ("if RUST_JSID_IS_STRING(id) {\n" + CGIndenter(CGProxyNamedSetter(self.descriptor)).define() + - " (*opresult).code_ = 0; /* SpecialCodes::OkCode */\n" + - " return true;\n" + + " return (*opresult).succeed();\n" + "} else {\n" + " return false;\n" + "}\n") @@ -4587,11 +4586,9 @@ class CGDOMJSProxyHandler_defineProperty(CGAbstractExternMethod): " //return js::IsInNonStrictPropertySet(cx)\n" + " // ? opresult.succeed()\n" + " // : ThrowErrorMessage(cx, MSG_NO_NAMED_SETTER, \"${name}\");\n" + - " (*opresult).code_ = 0; /* SpecialCodes::OkCode */\n" + - " return true;\n" + + " return (*opresult).succeed();\n" + " }\n" + - " (*opresult).code_ = 0; /* SpecialCodes::OkCode */\n" + - " return true;\n" + " return (*opresult).succeed();\n" "}\n") % (self.descriptor.name, self.descriptor.name) set += "return proxyhandler::define_property(%s);" % ", ".join(a.name for a in self.args) return set