Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-11 08:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Improve how intrinsic sizes work for videos (#31746)

Browse source 
* feat: patch for video layout sizes

added rebase from main 2024/10/05

Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: eri <epazos@igalia.com>

* feat: take width and height parameters if provided

Signed-off-by: eri <epazos@igalia.com>

* chore: tidy the code and update test expectations

Signed-off-by: eri <epazos@igalia.com>

* feat: handle removing poster

Signed-off-by: eri <epazos@igalia.com>

* chore: update test expectations and remove debug code

Signed-off-by: eri <epazos@igalia.com>

* fix: issues after rebasing to main

Signed-off-by: eri <epazos@igalia.com>

* feat: pass src remove test and tidy

Signed-off-by: eri <epazos@igalia.com>

* chore: clippy fixes

Signed-off-by: eri <epazos@igalia.com>

* chore: update passing test expectations

Signed-off-by: eri <epazos@igalia.com>

* fix object-position-svg test

Signed-off-by: eri <epazos@igalia.com>

* fix unintentional override of video size and resize events

Signed-off-by: eri <epazos@igalia.com>

* change how resize events are sent to better match the spec

Signed-off-by: eri <epazos@igalia.com>

* simplify poster mutation handling

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: eri <eri@inventati.org>

* improved handling of intrinsic sizes

- differentiate between natural size and css size
- presentational attributes
- fallback ratio for video element
- handle more cases where the src/poster are added/removed
- aspect ratio hints

Signed-off-by: eri <epazos@igalia.com>

* update test expectations

Signed-off-by: eri <epazos@igalia.com>

* fix cleaning current frame

Signed-off-by: eri <epazos@igalia.com>

* update test expectations

Signed-off-by: eri <epazos@igalia.com>

* Apply suggestions from code review

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: eri <eri@inventati.org>

* More code review suggestions

Signed-off-by: eri <epazos@igalia.com>

* Prevent aspect-ratio:auto from pulling the ratio from the default object size

As resolved in https://github.com/w3c/csswg-drafts/issues/7524#issuecomment-1204462924

Signed-off-by: Oriol Brufau <obrufau@igalia.com>

---------

Signed-off-by: eri <epazos@igalia.com>
Signed-off-by: eri <eri@inventati.org>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
eri 2024-10-29 22:42:22 +00:00 • committed by GitHub
parent 43d1601016
commit 01820e2a8a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 290 additions and 360 deletions
Download patch file Download diff file Expand all files Collapse all files

114
tests/wpt/meta/html/rendering/dimension-attributes.html.ini vendored
View file

@ -227,120 +227,6 @@
[<marquee height="0px"> mapping to <marquee> height property]
expected: FAIL
[<video width="200"> mapping to <video> width property]
expected: FAIL
[<video width="1007"> mapping to <video> width property]
expected: FAIL
[<video width=" 00523 "> mapping to <video> width property]
expected: FAIL
[<video width="200.25"> mapping to <video> width property]
expected: FAIL
[<video width="200.7"> mapping to <video> width property]
expected: FAIL
[<video width="200."> mapping to <video> width property]
expected: FAIL
[<video width="200in"> mapping to <video> width property]
expected: FAIL
[<video width="200.25in"> mapping to <video> width property]
expected: FAIL
[<video width="200 %"> mapping to <video> width property]
expected: FAIL
[<video width="200 abc"> mapping to <video> width property]
expected: FAIL
[<video width="200%"> mapping to <video> width property]
expected: FAIL
[<video width="200%abc"> mapping to <video> width property]
expected: FAIL
[<video width="200.25%"> mapping to <video> width property]
expected: FAIL
[<video width="200.%"> mapping to <video> width property]
expected: FAIL
[<video width="20.25e2"> mapping to <video> width property]
expected: FAIL
[<video width="20.25E2"> mapping to <video> width property]
expected: FAIL
[<video width="0"> mapping to <video> width property]
expected: FAIL
[<video width="0%"> mapping to <video> width property]
expected: FAIL
[<video width="0px"> mapping to <video> width property]
expected: FAIL
[<video height="200"> mapping to <video> height property]
expected: FAIL
[<video height="1007"> mapping to <video> height property]
expected: FAIL
[<video height=" 00523 "> mapping to <video> height property]
expected: FAIL
[<video height="200.25"> mapping to <video> height property]
expected: FAIL
[<video height="200.7"> mapping to <video> height property]
expected: FAIL
[<video height="200."> mapping to <video> height property]
expected: FAIL
[<video height="200in"> mapping to <video> height property]
expected: FAIL
[<video height="200.25in"> mapping to <video> height property]
expected: FAIL
[<video height="200 %"> mapping to <video> height property]
expected: FAIL
[<video height="200 abc"> mapping to <video> height property]
expected: FAIL
[<video height="200%"> mapping to <video> height property]
expected: FAIL
[<video height="200%abc"> mapping to <video> height property]
expected: FAIL
[<video height="200.25%"> mapping to <video> height property]
expected: FAIL
[<video height="200.%"> mapping to <video> height property]
expected: FAIL
[<video height="20.25e2"> mapping to <video> height property]
expected: FAIL
[<video height="20.25E2"> mapping to <video> height property]
expected: FAIL
[<video height="0"> mapping to <video> height property]
expected: FAIL
[<video height="0%"> mapping to <video> height property]
expected: FAIL
[<video height="0px"> mapping to <video> height property]
expected: FAIL
[<object width="200"> mapping to <object> width property]
expected: FAIL