diff --git a/Cargo.lock b/Cargo.lock index 11a5ab54f7a..e148dd0f9b2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -6728,7 +6728,6 @@ dependencies = [ "servo_allocator", "servo_config", "servo_malloc_size_of", - "signpost", "time", "tracing", ] @@ -8104,11 +8103,6 @@ dependencies = [ "libc", ] -[[package]] -name = "signpost" -version = "0.1.0" -source = "git+https://github.com/pcwalton/signpost.git#7ed712507f343c38646b9d1fefd049166f9c9a18" - [[package]] name = "simd-adler32" version = "0.3.7" diff --git a/components/config/opts.rs b/components/config/opts.rs index 0de34237aa3..64194db4ae9 100644 --- a/components/config/opts.rs +++ b/components/config/opts.rs @@ -133,10 +133,6 @@ pub struct DebugOptions { /// Log GC passes and their durations. pub gc_profile: bool, - - /// True to use OS native signposting facilities. This makes profiling events (script activity, - /// reflow, compositing, etc.) appear in Instruments.app on macOS. - pub signpost: bool, } impl DebugOptions { @@ -156,7 +152,6 @@ impl DebugOptions { "gc-profile" => self.gc_profile = true, "profile-script-events" => self.profile_script_events = true, "relayout-event" => self.relayout_event = true, - "signpost" => self.signpost = true, "" => {}, _ => return Err(String::from(option)), }; diff --git a/components/shared/profile/Cargo.toml b/components/shared/profile/Cargo.toml index 68a7df28c00..3a52d9c733d 100644 --- a/components/shared/profile/Cargo.toml +++ b/components/shared/profile/Cargo.toml @@ -24,6 +24,5 @@ malloc_size_of_derive = { workspace = true } serde = { workspace = true } servo_allocator = { path = "../../allocator" } servo_config = { path = "../../config" } -signpost = { git = "https://github.com/pcwalton/signpost.git" } time = { workspace = true } tracing = { workspace = true, optional = true } diff --git a/components/shared/profile/time.rs b/components/shared/profile/time.rs index 9e2059b11d0..b2dee281eab 100644 --- a/components/shared/profile/time.rs +++ b/components/shared/profile/time.rs @@ -7,7 +7,6 @@ use ipc_channel::ipc::IpcSender; use log::warn; use malloc_size_of_derive::MallocSizeOf; use serde::{Deserialize, Serialize}; -use servo_config::opts; use time::Duration; #[derive(Clone, Debug, Deserialize, Eq, Ord, PartialEq, PartialOrd, Serialize)] @@ -197,9 +196,6 @@ pub fn profile( where F: FnOnce() -> T, { - if opts::get().debug.signpost { - signpost::start(category as u32, &[0, 0, 0, (category as usize) >> 4]); - } let start_time = CrossProcessInstant::now(); let val = { #[cfg(feature = "tracing")] @@ -208,10 +204,6 @@ where }; let end_time = CrossProcessInstant::now(); - if opts::get().debug.signpost { - signpost::end(category as u32, &[0, 0, 0, (category as usize) >> 4]); - } - send_profile_data(category, meta, &profiler_chan, start_time, end_time); val } diff --git a/deny.toml b/deny.toml index b22dcf03718..bbd8fc6eb0c 100644 --- a/deny.toml +++ b/deny.toml @@ -205,4 +205,4 @@ skip = [ # github.com organizations to allow git sources for [sources.allow-org] -github = ["pcwalton", "servo", "linebender"] +github = ["servo", "linebender"] diff --git a/ports/servoshell/prefs.rs b/ports/servoshell/prefs.rs index 67de3e8def8..14df9bc00e3 100644 --- a/ports/servoshell/prefs.rs +++ b/ports/servoshell/prefs.rs @@ -769,10 +769,6 @@ fn print_debug_options_usage(app: &str) { "relayout-event", "Print notifications when there is a relayout.", ); - print_option( - "signpost", - "Emit native OS signposts for profile events (currently macOS only)", - ); println!();