Auto merge of #21062 - tigercosmos:ggg, r=emilio

textarea minLength/maxLength

<!-- Please describe your changes on the following line: -->
 textarea minLength/maxLength

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21062)
<!-- Reviewable:end -->

components/script/dom/htmltextareaelement.rs

@@ -105,10 +105,13 @@ impl LayoutHTMLTextAreaElementHelpers for LayoutDom<HTMLTextAreaElement> {
 }
 
 // https://html.spec.whatwg.org/multipage/#attr-textarea-cols-value
-static DEFAULT_COLS: u32 = 20;
+const DEFAULT_COLS: u32 = 20;
 
 // https://html.spec.whatwg.org/multipage/#attr-textarea-rows-value
-static DEFAULT_ROWS: u32 = 2;
+const DEFAULT_ROWS: u32 = 2;
+
+const DEFAULT_MAX_LENGTH: i32 = -1;
+const DEFAULT_MIN_LENGTH: i32 = -1;
 
 impl HTMLTextAreaElement {
     fn new_inherited(local_name: LocalName,
@@ -192,6 +195,18 @@ impl HTMLTextAreaElementMethods for HTMLTextAreaElement {
     // https://html.spec.whatwg.org/multipage/#dom-textarea-placeholder
     make_setter!(SetPlaceholder, "placeholder");
 
+    // https://html.spec.whatwg.org/multipage/#attr-textarea-maxlength
+    make_int_getter!(MaxLength, "maxlength", DEFAULT_MAX_LENGTH);
+
+    // https://html.spec.whatwg.org/multipage/#attr-textarea-maxlength
+    make_limited_int_setter!(SetMaxLength, "maxlength", DEFAULT_MAX_LENGTH);
+
+    // https://html.spec.whatwg.org/multipage/#attr-textarea-minlength
+    make_int_getter!(MinLength, "minlength", DEFAULT_MIN_LENGTH);
+
+    // https://html.spec.whatwg.org/multipage/#attr-textarea-minlength
+    make_limited_int_setter!(SetMinLength, "minlength", DEFAULT_MIN_LENGTH);
+
     // https://html.spec.whatwg.org/multipage/#attr-textarea-readonly
     make_bool_getter!(ReadOnly, "readonly");
 
@@ -369,6 +384,34 @@ impl VirtualMethods for HTMLTextAreaElement {
                     }
                 }
             },
+            local_name!("maxlength") => {
+                match *attr.value() {
+                    AttrValue::Int(_, value) => {
+                        let mut textinput = self.textinput.borrow_mut();
+
+                        if value < 0 {
+                            textinput.set_max_length(None);
+                        } else {
+                            textinput.set_max_length(Some(value as usize))
+                        }
+                    },
+                    _ => panic!("Expected an AttrValue::Int"),
+                }
+            },
+            local_name!("minlength") => {
+                match *attr.value() {
+                    AttrValue::Int(_, value) => {
+                        let mut textinput = self.textinput.borrow_mut();
+
+                        if value < 0 {
+                            textinput.set_min_length(None);
+                        } else {
+                            textinput.set_min_length(Some(value as usize))
+                        }
+                    },
+                    _ => panic!("Expected an AttrValue::Int"),
+                }
+            },
             local_name!("placeholder") => {
                 {
                     let mut placeholder = self.placeholder.borrow_mut();
@@ -409,6 +452,8 @@ impl VirtualMethods for HTMLTextAreaElement {
         match *name {
             local_name!("cols") => AttrValue::from_limited_u32(value.into(), DEFAULT_COLS),
             local_name!("rows") => AttrValue::from_limited_u32(value.into(), DEFAULT_ROWS),
+            local_name!("maxlength") => AttrValue::from_limited_i32(value.into(), DEFAULT_MAX_LENGTH),
+            local_name!("minlength") => AttrValue::from_limited_i32(value.into(), DEFAULT_MIN_LENGTH),
             _ => self.super_type().unwrap().parse_plain_attribute(name, value),
         }
     }

components/script/dom/webidls/HTMLTextAreaElement.webidl

@@ -18,10 +18,10 @@ interface HTMLTextAreaElement : HTMLElement {
   readonly attribute HTMLFormElement? form;
   // [CEReactions]
   //          attribute DOMString inputMode;
-  // [CEReactions]
-  //          attribute long maxLength;
-  // [CEReactions]
-  //          attribute long minLength;
+  [CEReactions, SetterThrows]
+           attribute long maxLength;
+  [CEReactions, SetterThrows]
+           attribute long minLength;
            attribute DOMString name;
   [CEReactions]
            attribute DOMString placeholder;