Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 05:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

adding .isConnected DOM attribute

Browse source
This commit is contained in:
Patrick Shaughnessy 2019-12-09 17:27:49 -05:00
parent daf7138f36
commit 0231a0a712
5 changed files with 11 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/node.rs
View file

@ -2296,6 +2296,11 @@ impl NodeMethods for Node {
USVString(String::from(self.owner_doc().base_url().as_str())) USVString(String::from(self.owner_doc().base_url().as_str()))
} }
// https://dom.spec.whatwg.org/#dom-node-isconnected
fn IsConnected(&self) -> bool {
return self.is_connected();
}
// https://dom.spec.whatwg.org/#dom-node-ownerdocument // https://dom.spec.whatwg.org/#dom-node-ownerdocument
fn GetOwnerDocument(&self) -> Option<DomRoot<Document>> { fn GetOwnerDocument(&self) -> Option<DomRoot<Document>> {
match self.type_id() { match self.type_id() {

3
components/script/dom/webidls/Node.webidl
View file

@ -28,6 +28,9 @@ interface Node : EventTarget {
[Pure] [Pure]
readonly attribute USVString baseURI; readonly attribute USVString baseURI;
[Pure]
readonly attribute boolean isConnected;
[Pure] [Pure]
readonly attribute Document? ownerDocument; readonly attribute Document? ownerDocument;

33
tests/wpt/metadata/dom/idlharness.window.js.ini
View file

@ -17,6 +17,9 @@
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "nextSibling" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "nextSibling" with the proper type]
expected: FAIL expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "isSameNode(Node)" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "isSameNode(Node)" with the proper type]
expected: FAIL expected: FAIL
@ -59,21 +62,12 @@
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "removeChild(Node)" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "removeChild(Node)" with the proper type]
expected: FAIL expected: FAIL
[Node interface: element must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.createComment("abc") must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: calling lookupPrefix(DOMString) on document.querySelector("[id\]").attributes[0\] with too few arguments must throw TypeError] [Node interface: calling lookupPrefix(DOMString) on document.querySelector("[id\]").attributes[0\] with too few arguments must throw TypeError]
expected: FAIL expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "PROCESSING_INSTRUCTION_NODE" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "PROCESSING_INSTRUCTION_NODE" with the proper type]
expected: FAIL expected: FAIL
[Node interface: new Document() must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "baseURI" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "baseURI" with the proper type]
expected: FAIL expected: FAIL
@ -107,12 +101,6 @@
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "childNodes" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "childNodes" with the proper type]
expected: FAIL expected: FAIL
[Node interface: document.createTextNode("abc") must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.doctype must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "parentElement" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "parentElement" with the proper type]
expected: FAIL expected: FAIL
@ -140,18 +128,9 @@
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "lookupNamespaceURI(DOMString)" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "lookupNamespaceURI(DOMString)" with the proper type]
expected: FAIL expected: FAIL
[Node interface: document.createDocumentFragment() must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: calling lookupNamespaceURI(DOMString) on document.querySelector("[id\]").attributes[0\] with too few arguments must throw TypeError] [Node interface: calling lookupNamespaceURI(DOMString) on document.querySelector("[id\]").attributes[0\] with too few arguments must throw TypeError]
expected: FAIL expected: FAIL
[Node interface: xmlDoc.createProcessingInstruction("abc", "def") must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: xmlDoc must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "firstChild" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "firstChild" with the proper type]
expected: FAIL expected: FAIL
@ -170,15 +149,9 @@
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "DOCUMENT_TYPE_NODE" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "DOCUMENT_TYPE_NODE" with the proper type]
expected: FAIL expected: FAIL
[Node interface: attribute isConnected]
expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "hasChildNodes()" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "hasChildNodes()" with the proper type]
expected: FAIL expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "isConnected" with the proper type]
expected: FAIL
[Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "lastChild" with the proper type] [Node interface: document.querySelector("[id\]").attributes[0\] must inherit property "lastChild" with the proper type]
expected: FAIL expected: FAIL

8
tests/wpt/metadata/dom/nodes/Node-isConnected.html.ini
View file

@ -1,8 +0,0 @@
[Node-isConnected.html]
type: testharness
[Test with ordinary child nodes]
expected: FAIL
[Test with iframes]
expected: FAIL

4
tests/wpt/metadata/html/semantics/forms/the-option-element/option-text-setter.html.ini
View file

@ -1,4 +0,0 @@
[option-text-setter.html]
[Verify that using HTMLOptionElement.text setter does not update the existing text child node.]
expected: FAIL