From 02dfee7b4746e5ef119b4be6599000c88eb9899d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Wed, 29 May 2019 16:29:30 +0200 Subject: [PATCH] Pass frame renderer to player only if video element Otherwise it will only render audio but no video frames. --- components/script/dom/htmlmediaelement.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs index 322065ca8fd..5d65ede8df5 100644 --- a/components/script/dom/htmlmediaelement.rs +++ b/components/script/dom/htmlmediaelement.rs @@ -1224,10 +1224,14 @@ impl HTMLMediaElement { }; let (action_sender, action_receiver) = ipc::channel().unwrap(); + let renderer: Option>> = match self.media_type_id() { + HTMLMediaElementTypeId::HTMLAudioElement => None, + HTMLMediaElementTypeId::HTMLVideoElement => Some(self.frame_renderer.clone()), + }; let player = ServoMedia::get().unwrap().create_player( stream_type, action_sender, - Some(self.frame_renderer.clone()), + renderer, Box::new(PlayerContextDummy()), );