From 032347f4ff9a2ce446525649b5c1f8a0d8e7fd04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Wed, 31 Jul 2019 18:18:21 +0000 Subject: [PATCH] style: Fix cursor prefixed aliases to do the right thing. This was an oversight in bug 1520154. We kept the -moz- version in the specified value but not the computed value. That's a very peculiar way of making aliases work. This makes them work consistently as many other aliases instead. Also, add an assert that would've caught this much much earlier. Differential Revision: https://phabricator.services.mozilla.com/D40063 --- components/style/values/specified/ui.rs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/components/style/values/specified/ui.rs b/components/style/values/specified/ui.rs index 0cc20d960c6..46272b2ae85 100644 --- a/components/style/values/specified/ui.rs +++ b/components/style/values/specified/ui.rs @@ -199,7 +199,9 @@ pub enum CursorKind { Move, NoDrop, NotAllowed, + #[parse(aliases = "-moz-grab")] Grab, + #[parse(aliases = "-moz-grabbing")] Grabbing, EResize, NResize, @@ -216,15 +218,9 @@ pub enum CursorKind { ColResize, RowResize, AllScroll, + #[parse(aliases = "-moz-zoom-in")] ZoomIn, + #[parse(aliases = "-moz-zoom-out")] ZoomOut, Auto, - #[cfg(feature = "gecko")] - MozGrab, - #[cfg(feature = "gecko")] - MozGrabbing, - #[cfg(feature = "gecko")] - MozZoomIn, - #[cfg(feature = "gecko")] - MozZoomOut, }