mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
cache frozen array of ports
This commit is contained in:
parent
e768ca1643
commit
0339601128
3 changed files with 32 additions and 4 deletions
|
@ -2,6 +2,7 @@
|
||||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||||
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
||||||
|
|
||||||
|
use crate::dom::bindings::cell::DomRefCell;
|
||||||
use crate::dom::bindings::codegen::Bindings::ExtendableMessageEventBinding;
|
use crate::dom::bindings::codegen::Bindings::ExtendableMessageEventBinding;
|
||||||
use crate::dom::bindings::codegen::Bindings::ExtendableMessageEventBinding::ExtendableMessageEventMethods;
|
use crate::dom::bindings::codegen::Bindings::ExtendableMessageEventBinding::ExtendableMessageEventMethods;
|
||||||
use crate::dom::bindings::error::Fallible;
|
use crate::dom::bindings::error::Fallible;
|
||||||
|
@ -32,6 +33,8 @@ pub struct ExtendableMessageEvent {
|
||||||
origin: DOMString,
|
origin: DOMString,
|
||||||
lastEventId: DOMString,
|
lastEventId: DOMString,
|
||||||
ports: Vec<Dom<MessagePort>>,
|
ports: Vec<Dom<MessagePort>>,
|
||||||
|
#[ignore_malloc_size_of = "mozjs"]
|
||||||
|
frozen_ports: DomRefCell<Option<Heap<JSVal>>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ExtendableMessageEvent {
|
impl ExtendableMessageEvent {
|
||||||
|
@ -49,6 +52,7 @@ impl ExtendableMessageEvent {
|
||||||
.into_iter()
|
.into_iter()
|
||||||
.map(|port| Dom::from_ref(&*port))
|
.map(|port| Dom::from_ref(&*port))
|
||||||
.collect(),
|
.collect(),
|
||||||
|
frozen_ports: DomRefCell::new(None),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -141,11 +145,22 @@ impl ExtendableMessageEventMethods for ExtendableMessageEvent {
|
||||||
|
|
||||||
/// https://w3c.github.io/ServiceWorker/#extendablemessage-event-ports
|
/// https://w3c.github.io/ServiceWorker/#extendablemessage-event-ports
|
||||||
fn Ports(&self, cx: JSContext) -> JSVal {
|
fn Ports(&self, cx: JSContext) -> JSVal {
|
||||||
|
if let Some(ports) = &*self.frozen_ports.borrow() {
|
||||||
|
return ports.get();
|
||||||
|
}
|
||||||
|
|
||||||
let ports: Vec<DomRoot<MessagePort>> = self
|
let ports: Vec<DomRoot<MessagePort>> = self
|
||||||
.ports
|
.ports
|
||||||
.iter()
|
.iter()
|
||||||
.map(|port| DomRoot::from_ref(&**port))
|
.map(|port| DomRoot::from_ref(&**port))
|
||||||
.collect();
|
.collect();
|
||||||
to_frozen_array(ports.as_slice(), cx)
|
let frozen_ports = to_frozen_array(ports.as_slice(), cx);
|
||||||
|
|
||||||
|
// Cache the Js value.
|
||||||
|
let heap_val = Heap::default();
|
||||||
|
heap_val.set(frozen_ports);
|
||||||
|
*self.frozen_ports.borrow_mut() = Some(heap_val);
|
||||||
|
|
||||||
|
frozen_ports
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -61,6 +61,8 @@ pub struct MessageEvent {
|
||||||
source: DomRefCell<Option<SrcObject>>,
|
source: DomRefCell<Option<SrcObject>>,
|
||||||
lastEventId: DomRefCell<DOMString>,
|
lastEventId: DomRefCell<DOMString>,
|
||||||
ports: DomRefCell<Vec<Dom<MessagePort>>>,
|
ports: DomRefCell<Vec<Dom<MessagePort>>>,
|
||||||
|
#[ignore_malloc_size_of = "mozjs"]
|
||||||
|
frozen_ports: DomRefCell<Option<Heap<JSVal>>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl MessageEvent {
|
impl MessageEvent {
|
||||||
|
@ -82,6 +84,7 @@ impl MessageEvent {
|
||||||
.map(|port| Dom::from_ref(&*port))
|
.map(|port| Dom::from_ref(&*port))
|
||||||
.collect(),
|
.collect(),
|
||||||
),
|
),
|
||||||
|
frozen_ports: DomRefCell::new(None),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -238,13 +241,24 @@ impl MessageEventMethods for MessageEvent {
|
||||||
|
|
||||||
/// <https://html.spec.whatwg.org/multipage/#dom-messageevent-ports>
|
/// <https://html.spec.whatwg.org/multipage/#dom-messageevent-ports>
|
||||||
fn Ports(&self, cx: JSContext) -> JSVal {
|
fn Ports(&self, cx: JSContext) -> JSVal {
|
||||||
|
if let Some(ports) = &*self.frozen_ports.borrow() {
|
||||||
|
return ports.get();
|
||||||
|
}
|
||||||
|
|
||||||
let ports: Vec<DomRoot<MessagePort>> = self
|
let ports: Vec<DomRoot<MessagePort>> = self
|
||||||
.ports
|
.ports
|
||||||
.borrow()
|
.borrow()
|
||||||
.iter()
|
.iter()
|
||||||
.map(|port| DomRoot::from_ref(&**port))
|
.map(|port| DomRoot::from_ref(&**port))
|
||||||
.collect();
|
.collect();
|
||||||
to_frozen_array(ports.as_slice(), cx)
|
let frozen_ports = to_frozen_array(ports.as_slice(), cx);
|
||||||
|
|
||||||
|
// Cache the Js value.
|
||||||
|
let heap_val = Heap::default();
|
||||||
|
heap_val.set(frozen_ports);
|
||||||
|
*self.frozen_ports.borrow_mut() = Some(heap_val);
|
||||||
|
|
||||||
|
frozen_ports
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <https://html.spec.whatwg.org/multipage/#dom-messageevent-initmessageevent>
|
/// <https://html.spec.whatwg.org/multipage/#dom-messageevent-initmessageevent>
|
||||||
|
@ -268,6 +282,7 @@ impl MessageEventMethods for MessageEvent {
|
||||||
.into_iter()
|
.into_iter()
|
||||||
.map(|port| Dom::from_ref(&*port))
|
.map(|port| Dom::from_ref(&*port))
|
||||||
.collect();
|
.collect();
|
||||||
|
*self.frozen_ports.borrow_mut() = None;
|
||||||
self.event
|
self.event
|
||||||
.init_event(Atom::from(type_), bubbles, cancelable);
|
.init_event(Atom::from(type_), bubbles, cancelable);
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,7 +1,5 @@
|
||||||
[messageevent-constructor.https.html]
|
[messageevent-constructor.https.html]
|
||||||
type: testharness
|
type: testharness
|
||||||
[ports attribute should be a FrozenArray]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[All parameters to initMessageEvent should be mandatory]
|
[All parameters to initMessageEvent should be mandatory]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue