Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #25201 - xu3u4:25183-add-onformdata-to-global-event-handler, r=jdm

Browse source 
Add onformdata to GlobalEventHandlers

<!-- Please describe your changes on the following line: -->
1. Adding `onformdata` to GlobalEventHandlers interface and global_event_handlers macro.
2. Deleting related FAIL tests.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25183 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2019-12-10 01:30:38 -05:00 • committed by GitHub
commit 03a47c803c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 2 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/script/dom/macros.rs
View file

@ -446,6 +446,7 @@ macro_rules! global_event_handlers(
event_handler!(emptied, GetOnemptied, SetOnemptied);
event_handler!(ended, GetOnended, SetOnended);
error_event_handler!(error, GetOnerror, SetOnerror);
event_handler!(formdata, GetOnformdata, SetOnformdata);
event_handler!(input, GetOninput, SetOninput);
event_handler!(invalid, GetOninvalid, SetOninvalid);
event_handler!(keydown, GetOnkeydown, SetOnkeydown);

1
components/script/dom/webidls/EventHandler.webidl
View file

@ -51,6 +51,7 @@ interface mixin GlobalEventHandlers {
attribute EventHandler onended;
attribute OnErrorEventHandler onerror;
attribute EventHandler onfocus;
attribute EventHandler onformdata;
attribute EventHandler oninput;
attribute EventHandler oninvalid;
attribute EventHandler onkeydown;

24
tests/wpt/metadata/html/dom/idlharness.https.html.ini
View file

@ -1543,9 +1543,6 @@
[Document interface: new Document() must inherit property "onsecuritypolicyviolation" with the proper type]
expected: FAIL
[Window interface: attribute onformdata]
expected: FAIL
[Document interface: calling queryCommandIndeterm(DOMString) on iframe.contentDocument with too few arguments must throw TypeError]
expected: FAIL
@ -1570,9 +1567,6 @@
[Document interface: attribute linkColor]
expected: FAIL
[Document interface: documentWithHandlers must inherit property "onformdata" with the proper type]
expected: FAIL
[Window interface: window must inherit property "scrollbars" with the proper type]
expected: FAIL
@ -1612,9 +1606,6 @@
[Document interface: new Document() must inherit property "queryCommandState(DOMString)" with the proper type]
expected: FAIL
[Window interface: window must inherit property "onformdata" with the proper type]
expected: FAIL
[Document interface: calling queryCommandEnabled(DOMString) on iframe.contentDocument with too few arguments must throw TypeError]
expected: FAIL
@ -1627,9 +1618,6 @@
[Window interface: window must inherit property "personalbar" with the proper type]
expected: FAIL
[Document interface: new Document() must inherit property "onformdata" with the proper type]
expected: FAIL
[Window interface: internal [[SetPrototypeOf\]\] method of interface prototype object - setting to a new value via __proto__ should throw a TypeError]
expected: FAIL
@ -1669,9 +1657,6 @@
[Document interface: attribute vlinkColor]
expected: FAIL
[Document interface: iframe.contentDocument must inherit property "onformdata" with the proper type]
expected: FAIL
[Document interface: iframe.contentDocument must inherit property "queryCommandEnabled(DOMString)" with the proper type]
expected: FAIL
@ -1702,9 +1687,6 @@
[Window interface: calling prompt(DOMString, DOMString) on window with too few arguments must throw TypeError]
expected: FAIL
[Document interface: attribute onformdata]
expected: FAIL
[Document interface: new Document() must inherit property "onauxclick" with the proper type]
expected: FAIL
@ -3621,9 +3603,6 @@
[HTMLOListElement interface: attribute reversed]
expected: FAIL
[HTMLElement interface: attribute onformdata]
expected: FAIL
[HTMLInputElement interface: createInput("text") must inherit property "willValidate" with the proper type]
expected: FAIL
@ -4473,9 +4452,6 @@
[HTMLInputElement interface: createInput("text") must inherit property "list" with the proper type]
expected: FAIL
[HTMLElement interface: document.createElement("noscript") must inherit property "onformdata" with the proper type]
expected: FAIL
[HTMLTableRowElement interface: document.createElement("tr") must inherit property "ch" with the proper type]
expected: FAIL

3
tests/wpt/metadata/html/webappapis/scripting/events/event-handler-all-global-events.html.ini
View file

@ -378,9 +378,6 @@
[onwaiting: the default value must be null]
expected: FAIL
[onformdata: the content attribute must be compiled into a function as the corresponding property]
expected: FAIL
[onformdata: must be on the appropriate locations for GlobalEventHandlers]
expected: FAIL

9
tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-body-window.html.ini
View file

@ -69,15 +69,6 @@
[shadowed error (window)]
expected: FAIL
[not shadowed formdata (window)]
expected: FAIL
[not shadowed formdata (document.body)]
expected: FAIL
[not shadowed formdata (document.createElement("body"))]
expected: FAIL
[not shadowed slotchange (window)]
expected: FAIL

9
tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-frameset-window.html.ini
View file

@ -62,15 +62,6 @@
[not shadowed auxclick (document.createElement("frameset"))]
expected: FAIL
[not shadowed formdata (document.body)]
expected: FAIL
[not shadowed formdata (document.createElement("frameset"))]
expected: FAIL
[not shadowed formdata (window)]
expected: FAIL
[not shadowed slotchange (window)]
expected: FAIL

6
tests/wpt/metadata/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html.ini
View file

@ -26,12 +26,6 @@
[securitypolicyviolation is unaffected on a windowless frameset]
expected: FAIL
[formdata is unaffected on a windowless frameset]
expected: FAIL
[formdata is unaffected on a windowless body]
expected: FAIL
[slotchange is unaffected on a windowless frameset]
expected: FAIL