Auto merge of #20559 - upsuper:cleanup-nscssvalue, r=emilio

Remove some unused stuff in nsCSSValue

This is the Servo side change of [bug 1448763](https://bugzilla.mozilla.org/show_bug.cgi?id=1448763).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20559)
<!-- Reviewable:end -->

components/style/gecko/generated/bindings.rs

@@ -80,7 +80,6 @@ use gecko_bindings::structs::nsCSSFontDesc;
 use gecko_bindings::structs::nsCSSKeyword;
 use gecko_bindings::structs::nsCSSPropertyID;
 use gecko_bindings::structs::nsCSSPropertyIDSet;
-use gecko_bindings::structs::nsCSSRect;
 use gecko_bindings::structs::nsCSSShadowArray;
 use gecko_bindings::structs::nsCSSUnit;
 use gecko_bindings::structs::nsCSSValue;
@@ -192,6 +191,9 @@ unsafe impl Sync for nsStyleSVGPaint {}
 use gecko_bindings::structs::nsStyleSVGReset;
 unsafe impl Send for nsStyleSVGReset {}
 unsafe impl Sync for nsStyleSVGReset {}
+use gecko_bindings::structs::nsStyleSides;
+unsafe impl Send for nsStyleSides {}
+unsafe impl Sync for nsStyleSides {}
 use gecko_bindings::structs::nsStyleTable;
 unsafe impl Send for nsStyleTable {}
 unsafe impl Sync for nsStyleTable {}
@@ -3359,11 +3361,17 @@ extern "C" {
     ) -> bool;
 }
 extern "C" {
-    pub fn Servo_ParseIntersectionObserverRootMargin(
+    pub fn Servo_IntersectionObserverRootMargin_Parse(
         value: *const nsAString,
-        result: *mut nsCSSRect,
+        result: *mut nsStyleSides,
     ) -> bool;
 }
+extern "C" {
+    pub fn Servo_IntersectionObserverRootMargin_ToString(
+        rect: *const nsStyleSides,
+        result: *mut nsAString,
+    );
+}
 extern "C" {
     pub fn Servo_ParseTransformIntoMatrix(
         value: *const nsAString,

components/style/gecko_bindings/sugar/ns_css_value.rs

@@ -7,7 +7,7 @@
 use gecko_bindings::bindings;
 use gecko_bindings::structs;
 use gecko_bindings::structs::{nsCSSValue, nsCSSUnit};
-use gecko_bindings::structs::{nsCSSValue_Array, nsCSSValueList, nscolor};
+use gecko_bindings::structs::{nsCSSValue_Array, nsCSSValueList};
 use gecko_string_cache::Atom;
 use std::marker::PhantomData;
 use std::mem;
@@ -33,33 +33,20 @@ impl nsCSSValue {
     /// builds.
     pub fn integer_unchecked(&self) -> i32 {
         debug_assert!(self.mUnit == nsCSSUnit::eCSSUnit_Integer ||
-                      self.mUnit == nsCSSUnit::eCSSUnit_Enumerated ||
+                      self.mUnit == nsCSSUnit::eCSSUnit_Enumerated);
-                      self.mUnit == nsCSSUnit::eCSSUnit_EnumColor);
         unsafe { *self.mValue.mInt.as_ref() }
     }
 
     /// Checks if it is an integer and returns it if so
     pub fn integer(&self) -> Option<i32> {
         if self.mUnit == nsCSSUnit::eCSSUnit_Integer ||
-           self.mUnit == nsCSSUnit::eCSSUnit_Enumerated ||
+           self.mUnit == nsCSSUnit::eCSSUnit_Enumerated {
-           self.mUnit == nsCSSUnit::eCSSUnit_EnumColor {
             Some(unsafe { *self.mValue.mInt.as_ref() })
         } else {
             None
         }
     }
 
-    /// Checks if it is an RGBA color, returning it if so
-    /// Only use it with colors set by SetColorValue(),
-    /// which always sets RGBA colors
-    pub fn color_value(&self) -> Option<nscolor> {
-        if self.mUnit == nsCSSUnit::eCSSUnit_RGBAColor {
-            Some(unsafe { *self.mValue.mColor.as_ref() })
-        } else {
-            None
-        }
-    }
-
     /// Returns this nsCSSValue value as a floating point value, unchecked in
     /// release builds.
     pub fn float_unchecked(&self) -> f32 {

components/style/values/specified/gecko.rs

@@ -5,12 +5,14 @@
 //! Specified types for legacy Gecko-only properties.
 
 use cssparser::{Parser, Token};
-use gecko_bindings::structs;
+use gecko::values::GeckoStyleCoordConvertible;
-use gecko_bindings::sugar::ns_css_value::ToNsCssValue;
+use gecko_bindings::sugar::ns_style_coord::{CoordData, CoordDataMut};
 use parser::{Parse, ParserContext};
-use style_traits::{ParseError, StyleParseErrorKind};
+use std::fmt;
-use values::CSSFloat;
+use style_traits::{CssWriter, ParseError, StyleParseErrorKind, ToCss};
+use style_traits::values::SequenceWriter;
 use values::computed;
+use values::computed::length::CSSPixelLength;
 use values::generics::gecko::ScrollSnapPoint as GenericScrollSnapPoint;
 use values::generics::rect::Rect;
 use values::specified::length::LengthOrPercentage;
@@ -32,10 +34,10 @@ impl Parse for ScrollSnapPoint {
 }
 
 /// A component of an IntersectionObserverRootMargin.
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, ToCss)]
 pub enum PixelOrPercentage {
     /// An absolute length in pixels (px)
-    Px(CSSFloat),
+    Pixel(CSSPixelLength),
     /// A percentage (%)
     Percentage(computed::Percentage),
 }
@@ -50,7 +52,7 @@ impl Parse for PixelOrPercentage {
         let value = match *token {
             Token::Dimension { value, ref unit, .. } => {
                 match_ignore_ascii_case! { unit,
-                    "px" => Ok(PixelOrPercentage::Px(value)),
+                    "px" => Ok(PixelOrPercentage::Pixel(CSSPixelLength::new(value))),
                     _ => Err(()),
                 }
             }
@@ -67,17 +69,22 @@ impl Parse for PixelOrPercentage {
     }
 }
 
-impl ToNsCssValue for PixelOrPercentage {
+impl GeckoStyleCoordConvertible for PixelOrPercentage {
-    fn convert(self, nscssvalue: &mut structs::nsCSSValue) {
+    fn to_gecko_style_coord<T: CoordDataMut>(&self, coord: &mut T) {
-        match self {
+        match *self {
-            PixelOrPercentage::Px(px) => {
+            PixelOrPercentage::Pixel(ref l) => l.to_gecko_style_coord(coord),
-                unsafe { nscssvalue.set_px(px); }
+            PixelOrPercentage::Percentage(ref pc) => pc.to_gecko_style_coord(coord),
-            }
-            PixelOrPercentage::Percentage(pc) => {
-                unsafe { nscssvalue.set_percentage(pc.0); }
-            }
         }
     }
+
+    fn from_gecko_style_coord<T: CoordData>(coord: &T) -> Option<Self> {
+        CSSPixelLength::from_gecko_style_coord(coord)
+            .map(PixelOrPercentage::Pixel)
+            .or_else(|| {
+                computed::Percentage::from_gecko_style_coord(coord)
+                    .map(PixelOrPercentage::Percentage)
+            })
+    }
 }
 
 /// The value of an IntersectionObserver's rootMargin property.
@@ -97,3 +104,20 @@ impl Parse for IntersectionObserverRootMargin {
         Ok(IntersectionObserverRootMargin(rect))
     }
 }
+
+// Strictly speaking this is not ToCss. It's serializing for DOM. But
+// we can just reuse the infrastructure of this.
+//
+// <https://w3c.github.io/IntersectionObserver/#dom-intersectionobserver-rootmargin>
+impl ToCss for IntersectionObserverRootMargin {
+    fn to_css<W>(&self, dest: &mut CssWriter<W>) -> fmt::Result where W: fmt::Write {
+        // We cannot use the ToCss impl of Rect, because that would
+        // merge items when they are equal. We want to list them all.
+        let mut writer = SequenceWriter::new(dest, " ");
+        let rect = &self.0;
+        writer.item(&rect.0)?;
+        writer.item(&rect.1)?;
+        writer.item(&rect.2)?;
+        writer.item(&rect.3)
+    }
+}

ports/geckolib/glue.rs

@@ -157,8 +157,9 @@ use style::values::{CustomIdent, KeyframesName};
 use style::values::animated::{Animate, Procedure, ToAnimatedZero};
 use style::values::computed::{Context, ToComputedValue};
 use style::values::distance::ComputeSquaredDistance;
+use style::values::generics::rect::Rect;
 use style::values::specified;
-use style::values::specified::gecko::IntersectionObserverRootMargin;
+use style::values::specified::gecko::{IntersectionObserverRootMargin, PixelOrPercentage};
 use style::values::specified::source_size_list::SourceSizeList;
 use style_traits::{CssWriter, ParsingMode, StyleParseErrorKind, ToCss};
 use super::error_reporter::ErrorReporter;
@@ -5204,17 +5205,17 @@ pub extern "C" fn Servo_ComputeColor(
 }
 
 #[no_mangle]
-pub extern "C" fn Servo_ParseIntersectionObserverRootMargin(
+pub unsafe extern "C" fn Servo_IntersectionObserverRootMargin_Parse(
     value: *const nsAString,
-    result: *mut structs::nsCSSRect,
+    result: *mut structs::nsStyleSides,
 ) -> bool {
-    let value = unsafe { value.as_ref().unwrap().to_string() };
+    let value = value.as_ref().unwrap().to_string();
-    let result = unsafe { result.as_mut().unwrap() };
+    let result = result.as_mut().unwrap();
 
     let mut input = ParserInput::new(&value);
     let mut parser = Parser::new(&mut input);
 
-    let url_data = unsafe { dummy_url_data() };
+    let url_data = dummy_url_data();
     let context = ParserContext::new(
         Origin::Author,
         url_data,
@@ -5228,17 +5229,25 @@ pub extern "C" fn Servo_ParseIntersectionObserverRootMargin(
     });
     match margin {
         Ok(margin) => {
-            let rect = margin.0;
+            margin.0.to_gecko_rect(result);
-            result.mTop.set_from(rect.0);
-            result.mRight.set_from(rect.1);
-            result.mBottom.set_from(rect.2);
-            result.mLeft.set_from(rect.3);
             true
         }
         Err(..) => false,
     }
 }
 
+#[no_mangle]
+pub unsafe extern "C" fn Servo_IntersectionObserverRootMargin_ToString(
+    rect: *const structs::nsStyleSides,
+    result: *mut nsAString,
+) {
+    let rect = Rect::<PixelOrPercentage>::
+        from_gecko_rect(rect.as_ref().unwrap()).unwrap();
+    let root_margin = IntersectionObserverRootMargin(rect);
+    let mut writer = CssWriter::new(result.as_mut().unwrap());
+    root_margin.to_css(&mut writer).unwrap();
+}
+
 #[no_mangle]
 pub extern "C" fn Servo_ParseTransformIntoMatrix(
     value: *const nsAString,