mirror of
https://github.com/servo/servo.git
synced 2025-08-05 21:50:18 +01:00
This pull request refactors existing tracing annotations to leverage the new `servo_tracing::instrument` macro introduced in #36573. Specifically, the following transformations were applied: - Removed `#[cfg_attr(feature = "tracing", ...)]` wrappers. - Replaced `tracing::instrument` with `servo_tracing::instrument`. - Removed `level = "trace"` - Removed `fields(servo_profiling = true)` from tracing attributes however retained others like `name`. `skip type` Closes: #36661 --------- Signed-off-by: Bhuwan Pandit <bhuwanpandit109@gmail.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> Co-authored-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
This commit is contained in:
parent
bdf8c0ebc8
commit
04bcafa140
16 changed files with 137 additions and 527 deletions
|
@ -44,6 +44,7 @@ webrender = { workspace = true }
|
|||
webrender_api = { workspace = true }
|
||||
webxr = { path = "../webxr", optional = true }
|
||||
wr_malloc_size_of = { workspace = true }
|
||||
servo-tracing = { workspace = true }
|
||||
|
||||
[dev-dependencies]
|
||||
surfman = { workspace = true }
|
||||
|
|
|
@ -1503,10 +1503,7 @@ impl IOCompositor {
|
|||
}))
|
||||
}
|
||||
|
||||
#[cfg_attr(
|
||||
feature = "tracing",
|
||||
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
|
||||
)]
|
||||
#[servo_tracing::instrument(skip_all)]
|
||||
fn render_inner(&mut self) -> Result<(), UnableToComposite> {
|
||||
if let Err(err) = self.rendering_context.make_current() {
|
||||
warn!("Failed to make the rendering context current: {:?}", err);
|
||||
|
@ -1660,10 +1657,7 @@ impl IOCompositor {
|
|||
Ref::map(self.global.borrow(), |global| &global.compositor_receiver)
|
||||
}
|
||||
|
||||
#[cfg_attr(
|
||||
feature = "tracing",
|
||||
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
|
||||
)]
|
||||
#[servo_tracing::instrument(skip_all)]
|
||||
pub fn handle_messages(&mut self, mut messages: Vec<CompositorMsg>) {
|
||||
// Check for new messages coming from the other threads in the system.
|
||||
let mut found_recomposite_msg = false;
|
||||
|
@ -1700,10 +1694,7 @@ impl IOCompositor {
|
|||
}
|
||||
}
|
||||
|
||||
#[cfg_attr(
|
||||
feature = "tracing",
|
||||
tracing::instrument(skip_all, fields(servo_profiling = true), level = "trace")
|
||||
)]
|
||||
#[servo_tracing::instrument(skip_all)]
|
||||
pub fn perform_updates(&mut self) -> bool {
|
||||
if self.global.borrow().shutdown_state() == ShutdownState::FinishedShuttingDown {
|
||||
return false;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue