Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Don't append the default namespace for featureless host selectors.

Browse source 
Per the spec it shouldn't match, and the front-end has been bitten by this
multiple times.

Differential Revision: https://phabricator.services.mozilla.com/D68213
This commit is contained in:
Emilio Cobos Álvarez 2020-03-26 11:44:01 +00:00
parent 3004286308
commit 0514059618
1 changed files with 28 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

38
components/selectors/parser.rs
View file

@ -2013,27 +2013,45 @@ where
input.skip_whitespace(); input.skip_whitespace();
let mut empty = true; let mut empty = true;
if !parse_type_selector(parser, input, builder)? { if parse_type_selector(parser, input, builder)? {
if let Some(url) = parser.default_namespace() {
// If there was no explicit type selector, but there is a
// default namespace, there is an implicit "<defaultns>|*" type
// selector.
builder.push_simple_selector(Component::DefaultNamespace(url))
}
} else {
empty = false; empty = false;
} }
let mut state = SelectorParsingState::empty(); let mut state = SelectorParsingState::empty();
loop { loop {
let parse_result = match parse_one_simple_selector(parser, input, state)? { let result = match parse_one_simple_selector(parser, input, state)? {
None => break, None => break,
Some(result) => result, Some(result) => result,
}; };
if empty {
if let Some(url) = parser.default_namespace() {
// If there was no explicit type selector, but there is a
// default namespace, there is an implicit "<defaultns>|*" type
// selector. Except for :host, where we ignore it.
//
// https://drafts.csswg.org/css-scoping/#host-element-in-tree:
//
// When considered within its own shadow trees, the shadow
// host is featureless. Only the :host, :host(), and
// :host-context() pseudo-classes are allowed to match it.
//
// https://drafts.csswg.org/selectors-4/#featureless:
//
// A featureless element does not match any selector at all,
// except those it is explicitly defined to match. If a
// given selector is allowed to match a featureless element,
// it must do so while ignoring the default namespace.
//
if !matches!(result, SimpleSelectorParseResult::SimpleSelector(Component::Host(..))) {
builder.push_simple_selector(Component::DefaultNamespace(url));
}
}
}
empty = false; empty = false;
match parse_result { match result {
SimpleSelectorParseResult::SimpleSelector(s) => { SimpleSelectorParseResult::SimpleSelector(s) => {
builder.push_simple_selector(s); builder.push_simple_selector(s);
}, },