Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-09 06:28:22 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #10826 - danlrobertson:cookies, r=asajeffrey

Browse source 
Add webdriver commands for (Get|Add)Cookie

Add the webdriver commands for GetCookie and AddCookie. In addition the basic messages for sending cookie data back and forth from the resource thread needed to be created and the handlers for those messages were created as well.

Do we plan to have some sort of test suite for the webdriver at some point? At this point I primarily test my PRs with basic shell scripts with a lot of `curl` and `jq`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10826)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-06-26 03:19:14 -05:00 • committed by GitHub
commit 054bb381e9
19 changed files with 214 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/unit/net/cookie_http_state.rs
View file

@ -288,7 +288,6 @@ fn test_attribute0003() {
}
#[test]
#[should_panic] // Look at cookie_http_state_utils.py if this test fails
fn test_attribute0004() {
let r = run("http://home.example.org:8888/cookie-parser?attribute0004",
&["foo=bar; Secure="],
@ -297,7 +296,6 @@ fn test_attribute0004() {
}
#[test]
#[should_panic] // Look at cookie_http_state_utils.py if this test fails
fn test_attribute0005() {
let r = run("http://home.example.org:8888/cookie-parser?attribute0005",
&["foo=bar; Secure=aaaa"],
@ -314,7 +312,6 @@ fn test_attribute0006() {
}
#[test]
#[should_panic] // Look at cookie_http_state_utils.py if this test fails
fn test_attribute0007() {
let r = run("http://home.example.org:8888/cookie-parser?attribute0007",
&["foo=bar; Secure =aaaaa"],
@ -323,7 +320,6 @@ fn test_attribute0007() {
}
#[test]
#[should_panic] // Look at cookie_http_state_utils.py if this test fails
fn test_attribute0008() {
let r = run("http://home.example.org:8888/cookie-parser?attribute0008",
&["foo=bar; Secure= aaaaa"],

4
tests/unit/net/cookie_http_state_utils.py
View file

@ -23,10 +23,6 @@ SHOULD_PANIC = "\n#[should_panic] // Look at cookie_http_state_utils.py if this
# Those tests should PASS. But until fixes land in servo, keep them failing
FAILING_TESTS = [
"attribute0004", # Waiting for issue 46 of alexcrichton/cookie-rs
"attribute0005", # Waiting for issue 46 of alexcrichton/cookie-rs
"attribute0007", # Waiting for issue 46 of alexcrichton/cookie-rs
"attribute0008", # Waiting for issue 46 of alexcrichton/cookie-rs
"0003", # Waiting for a way to clean expired cookies
"0006", # Waiting for a way to clean expired cookies
"mozilla0001", # Waiting for a way to clean expired cookies