From e5892989caf418fe2b9990c61d19de55c47baf55 Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Thu, 27 Sep 2018 18:44:02 -0400 Subject: [PATCH 1/2] Warn when using slow WebGL code path. --- components/canvas/webgl_thread.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/components/canvas/webgl_thread.rs b/components/canvas/webgl_thread.rs index 9256692599a..682993cefd3 100644 --- a/components/canvas/webgl_thread.rs +++ b/components/canvas/webgl_thread.rs @@ -220,7 +220,9 @@ impl WebGLThread { // Fallback to readback mode if the shared context creation fails. let result = self.gl_factory.new_shared_context(version, size, attributes) .map(|r| (r, WebGLContextShareMode::SharedTexture)) - .or_else(|_| { + .or_else(|err| { + warn!("Couldn't create shared GL context ({}), using slow \ + readback context instead.", err); let ctx = self.gl_factory.new_context(version, size, attributes); ctx.map(|r| (r, WebGLContextShareMode::Readback)) }); From 26e1001efd70e5df4db8af268f7d896634d45b8c Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Mon, 1 Oct 2018 13:32:34 +0200 Subject: [PATCH 2/2] Remove trailing whitespace. --- components/canvas/webgl_thread.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/canvas/webgl_thread.rs b/components/canvas/webgl_thread.rs index 682993cefd3..c6d9082b7e0 100644 --- a/components/canvas/webgl_thread.rs +++ b/components/canvas/webgl_thread.rs @@ -222,7 +222,7 @@ impl WebGLThread { .map(|r| (r, WebGLContextShareMode::SharedTexture)) .or_else(|err| { warn!("Couldn't create shared GL context ({}), using slow \ - readback context instead.", err); + readback context instead.", err); let ctx = self.gl_factory.new_context(version, size, attributes); ctx.map(|r| (r, WebGLContextShareMode::Readback)) });