Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 16:49:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: use Element::create instead of DOM struct constructors (#39325)

Browse source 
Creating elements by directly calling their interface constructors leads
to some state not being intialized correctly (see #39285). It is also
not in line with the specifications as many of them refer to the
[`create an element`][1] algorithm when an element needs to be created,
which directly maps to `Element::create` in the script crate.

So, switch all such places where elements are created by script to use
`Element::create`.

[1]: https://dom.spec.whatwg.org/#concept-create-element

Testing: Existing WPT tests.

Fixes: #39285

Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This commit is contained in:
Mukilan Thiyagarajan 2025-09-16 14:56:42 +05:30 • committed by GitHub
parent 2b261b02bf
commit 07b2ff5d60
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 254 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/html/htmlmeterelement.rs
View file

@ -6,7 +6,7 @@ use std::cell::Ref;
use std::ops::{Add, Div};
use dom_struct::dom_struct;
use html5ever::{LocalName, Prefix, local_name};
use html5ever::{LocalName, Prefix, QualName, local_name, ns};
use js::rust::HandleObject;
use stylo_dom::ElementState;
@ -20,7 +20,6 @@ use crate::dom::bindings::root::{Dom, DomRoot, MutNullableDom};
use crate::dom::bindings::str::DOMString;
use crate::dom::document::Document;
use crate::dom::element::{AttributeMutation, Element};
use crate::dom::html::htmldivelement::HTMLDivElement;
use crate::dom::html::htmlelement::HTMLElement;
use crate::dom::node::{BindContext, ChildrenMutation, Node, NodeTraits};
use crate::dom::nodelist::NodeList;
@ -38,7 +37,7 @@ pub(crate) struct HTMLMeterElement {
#[derive(Clone, JSTraceable, MallocSizeOf)]
#[cfg_attr(crown, crown::unrooted_must_root_lint::must_root)]
struct ShadowTree {
meter_value: Dom<HTMLDivElement>,
meter_value: Dom<Element>,
}
/// <https://html.spec.whatwg.org/multipage/#the-meter-element>
@ -77,7 +76,15 @@ impl HTMLMeterElement {
let document = self.owner_document();
let root = self.upcast::<Element>().attach_ua_shadow_root(true, can_gc);
let meter_value = HTMLDivElement::new(local_name!("div"), None, &document, None, can_gc);
let meter_value = Element::create(
QualName::new(None, ns!(html), local_name!("div")),
None,
&document,
crate::dom::element::ElementCreator::ScriptCreated,
crate::dom::element::CustomElementCreationMode::Asynchronous,
None,
can_gc,
);
root.upcast::<Node>()
.AppendChild(meter_value.upcast::<Node>(), can_gc)
.unwrap();
@ -153,7 +160,6 @@ impl HTMLMeterElement {
let style = format!("width: {position}%");
shadow_tree
.meter_value
.upcast::<Element>()
.set_string_attribute(&local_name!("style"), style.into(), can_gc);
}
}