Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-02 20:20:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Don't count lines that consist solely of hypothetical boxes when

Browse source 
determining the baseline offset of the last line.

Improves Twitter by placing the favorite icon in the right place
vertically.
This commit is contained in:
Patrick Walton 2016-09-27 18:26:40 -07:00
parent 3a56cc7f2f
commit 0803ef98e3
4 changed files with 46 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/layout/inline.rs
View file

@ -1262,13 +1262,16 @@ impl InlineFlow {
}
pub fn baseline_offset_of_last_line(&self) -> Option<Au> {
match self.lines.last() {
None => None,
Some(ref last_line) => {
Some(last_line.bounds.start.b + last_line.bounds.size.block -
last_line.inline_metrics.depth_below_baseline)
// Find the last line that doesn't consist entirely of hypothetical boxes.
for line in self.lines.iter().rev() {
if (line.range.begin().get()..line.range.end().get()).any(|index| {
!self.fragments.fragments[index as usize].is_hypothetical()
}) {
return Some(line.bounds.start.b + line.bounds.size.block -
line.inline_metrics.depth_below_baseline)
}
}
None
}
}