Auto merge of #25358 - pshaughn:looser_header_validation, r=jdm

Header values no longer have to be ASCII or UTF-8

<!-- Please describe your changes on the following line: -->
This passes some failed tests related to header validity when handling ByteStrings outside the printable ASCII range. A few failures remain because the HeaderValue class is stricter than WHATWG/WPT, disallowing various control-code bytes that the spec and tests expect to be allowed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix some of the test cases described in #24903

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-01-02 21:05:08 -05:00 committed by GitHub
commit 097a91112e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 55 additions and 123 deletions

View file

@ -1,23 +0,0 @@
[request-forbidden-headers.any.html]
type: testharness
[Accept-Encoding is a forbidden request header]
expected: FAIL
[Access-Control-Request-Headers is a forbidden request header]
expected: FAIL
[Access-Control-Request-Method is a forbidden request header]
expected: FAIL
[request-forbidden-headers.any.worker.html]
type: testharness
[Accept-Encoding is a forbidden request header]
expected: FAIL
[Access-Control-Request-Headers is a forbidden request header]
expected: FAIL
[Access-Control-Request-Method is a forbidden request header]
expected: FAIL

View file

@ -48,15 +48,6 @@
[fetch() with value %08]
expected: FAIL
[fetch() with value %09]
expected: FAIL
[fetch() with value %0A]
expected: FAIL
[fetch() with value %0D]
expected: FAIL
[XMLHttpRequest with value %0E]
expected: FAIL
@ -164,7 +155,3 @@
[fetch() with value %1F]
expected: FAIL
[fetch() with value %20]
expected: FAIL

View file

@ -1,10 +1,4 @@
[headers-no-cors.window.html]
["no-cors" Headers object cannot have accept-language/\x01 as header]
expected: FAIL
["no-cors" Headers object cannot have content-language/\x01 as header]
expected: FAIL
["no-cors" Headers object cannot have content-type set to text/plain;ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss, text/plain]
expected: FAIL

View file

@ -1,5 +0,0 @@
[request-headers.html]
type: testharness
[Testing empty Request Content-Type header]
expected: FAIL

View file

@ -3,9 +3,6 @@
[Read Response's body as readableStream]
expected: FAIL
[Testing empty Response Content-Type header]
expected: FAIL
[Testing null Response body]
expected: FAIL