From 097bd9d87f268412d7490528ef89a7f675915a7d Mon Sep 17 00:00:00 2001 From: Kenzie Raditya Tirtarahardja Date: Fri, 6 Jun 2025 20:39:15 +0800 Subject: [PATCH] Fix mistakes in webdriver element send keys (#37286) Fix mistakes from https://github.com/servo/servo/pull/37224. We should return in the middle of send keys if the element is either file input or non typeable form control. Fixes: https://github.com/servo/servo/pull/37224#pullrequestreview-2903871157 Signed-off-by: PotatoCP --- components/webdriver_server/lib.rs | 2 +- .../tests/classic/element_send_keys/form_controls.py.ini | 3 +++ .../webdriver/tests/classic/element_send_keys/send_keys.py.ini | 3 --- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/components/webdriver_server/lib.rs b/components/webdriver_server/lib.rs index adb65ff6cd9..1b585319703 100644 --- a/components/webdriver_server/lib.rs +++ b/components/webdriver_server/lib.rs @@ -1633,7 +1633,7 @@ impl Handler { // TODO: distinguish the not found and not focusable cases // File input and non-typeable form control should have // been handled in `webdriver_handler.rs`. - if wait_for_script_response(receiver)?.map_err(|error| WebDriverError::new(error, ""))? { + if !wait_for_script_response(receiver)?.map_err(|error| WebDriverError::new(error, ""))? { return Ok(WebDriverResponse::Void); } diff --git a/tests/wpt/meta/webdriver/tests/classic/element_send_keys/form_controls.py.ini b/tests/wpt/meta/webdriver/tests/classic/element_send_keys/form_controls.py.ini index 5d4a3bd4de5..1dea194f9b2 100644 --- a/tests/wpt/meta/webdriver/tests/classic/element_send_keys/form_controls.py.ini +++ b/tests/wpt/meta/webdriver/tests/classic/element_send_keys/form_controls.py.ini @@ -4,3 +4,6 @@ [test_textarea_append] expected: FAIL + + [test_date] + expected: FAIL diff --git a/tests/wpt/meta/webdriver/tests/classic/element_send_keys/send_keys.py.ini b/tests/wpt/meta/webdriver/tests/classic/element_send_keys/send_keys.py.ini index e4999c2daca..9dca7adc465 100644 --- a/tests/wpt/meta/webdriver/tests/classic/element_send_keys/send_keys.py.ini +++ b/tests/wpt/meta/webdriver/tests/classic/element_send_keys/send_keys.py.ini @@ -7,6 +7,3 @@ [test_no_such_element_from_other_window_handle[closed\]] expected: FAIL - - [test_surrogates] - expected: FAIL