Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Allow 16% false positives in test bloom::create_and_insert_some_stuff.

Browse source 
It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32bit platforms, the numbers become 157 and 16 correspondingly.

16 is still less than 20% in the second part, so all fine, but 157 is
slightly larger than 15% in the test assertion. Given it is what we are
shipping, we probably should just accept this and loosen the assertion.

Bug: 1457524
Reviewed-by: heycam
MozReview-Commit-ID: 9kFXBzLFAzE
This commit is contained in:
Xidorn Quan 2018-05-02 21:07:07 +10:00 • committed by Emilio Cobos Álvarez
parent 12913d048f
commit 09b22ab2dc
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/selectors/bloom.rs
View file

@ -335,7 +335,7 @@ fn create_and_insert_some_stuff() {
let false_positives = (1001_usize..2000).filter(|i| bf.might_contain(i)).count();
assert!(false_positives < 150, "{} is not < 150", false_positives); // 15%.
assert!(false_positives < 160, "{} is not < 160", false_positives); // 16%.
for i in 0_usize..100 {
bf.remove(&i);