mirror of
https://github.com/servo/servo.git
synced 2025-08-02 20:20:14 +01:00
Auto merge of #17218 - canaltinova:transform-bug, r=emilio
Don't accept an extra token at the end of transform property The lack of `input.try` usage makes transform property to accept values like `rotate(70deg)foo`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17218) <!-- Reviewable:end -->
This commit is contained in:
commit
09b4f79ed3
2 changed files with 8 additions and 1 deletions
|
@ -956,7 +956,7 @@ ${helpers.predefined_type("scroll-snap-coordinate",
|
||||||
|
|
||||||
let mut result = Vec::new();
|
let mut result = Vec::new();
|
||||||
loop {
|
loop {
|
||||||
let name = match input.expect_function() {
|
let name = match input.try(|i| i.expect_function()) {
|
||||||
Ok(name) => name,
|
Ok(name) => name,
|
||||||
Err(_) => break,
|
Err(_) => break,
|
||||||
};
|
};
|
||||||
|
|
|
@ -31,3 +31,10 @@ fn test_transform_translate() {
|
||||||
assert!(parse(transform::parse, "translate(2px foo)").is_err());
|
assert!(parse(transform::parse, "translate(2px foo)").is_err());
|
||||||
assert!(parse(transform::parse, "perspective(-10px)").is_err());
|
assert!(parse(transform::parse, "perspective(-10px)").is_err());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_unexhausted_transform() {
|
||||||
|
use style::properties::longhands::transform;
|
||||||
|
assert_parser_exhausted!(transform::parse, "rotate(70deg)foo", false);
|
||||||
|
assert_parser_exhausted!(transform::parse, "rotate(70deg) foo", false);
|
||||||
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue