Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-26 23:58:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Remove workaround for body while building overflow frame for StackingContextTree construction. (#38825)

Browse source 
While building the stacking context tree we were assuming that `<body>`
would have propagated its `overflow` value to the viewport, and thus its
used `overflow` would be `visible`.

However, the element that propagates `overflow` can be the root element
instead. Since #38598 we are correctly taking this into account in
`effective_overflow()`, so we no longer need to do anything special in
the stacking context logic.

Testing: `css/css-overflow/overflow-body-propagation-012.html`

Fixes: #38799

Signed-off-by: Shubham Gupta <shubham13297@gmail.com>
This commit is contained in:
Shubham Gupta 2025-08-22 15:59:02 +08:00 • committed by GitHub
parent 4784ff0375
commit 09db6b8669
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 61 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

19
components/layout/display_list/stacking_context.rs
View file

@ -1449,25 +1449,6 @@ impl BoxFragment {
}); });
} }
// scrollable overflow path
// From https://drafts.csswg.org/css-overflow/#propdef-overflow:
// > UAs must apply the overflow-* values set on the root element to the viewport when the
// > root element’s display value is not none. However, when the root element is an [HTML]
// > html element (including XML syntax for HTML) whose overflow value is visible (in both
// > axes), and that element has as a child a body element whose display value is also not
// > none, user agents must instead apply the overflow-* values of the first such child
// > element to the viewport. The element from which the value is propagated must then have a
// > used overflow value of visible.
//
// TODO: This should only happen when the `display` value is actually propagated.
if self
.base
.flags
.contains(FragmentFlags::IS_BODY_ELEMENT_OF_HTML_ELEMENT_ROOT)
{
return None;
}
let scroll_frame_rect = self let scroll_frame_rect = self
.padding_rect() .padding_rect()
.translate(containing_block_rect.origin.to_vector()) .translate(containing_block_rect.origin.to_vector())

17
tests/wpt/meta/MANIFEST.json vendored
View file

@ -231653,6 +231653,19 @@
{} {}
] ]
], ],
"overflow-body-propagation-012.html": [
"483b92e79b4f362e7cb6b5a8020103f48798b21a",
[
null,
[
[
"/css/css-overflow/overflow-body-propagation-012-ref.html",
"=="
]
],
{}
]
],
"overflow-canvas.html": [ "overflow-canvas.html": [
"e9529cb0bc81202c5689a507435ea088028a97fc", "e9529cb0bc81202c5689a507435ea088028a97fc",
[ [
@ -446720,6 +446733,10 @@
"0d440ef20afa3d2456b702b2a1727a9f0717c4c1", "0d440ef20afa3d2456b702b2a1727a9f0717c4c1",
[] []
], ],
"overflow-body-propagation-012-ref.html": [
"06b64c94334582ca9674f26648ef2be9c3c0e6c2",
[]
],
"overflow-canvas-ref.html": [ "overflow-canvas-ref.html": [
"3ad440e371906b2fa4bc2ec4ae5c430267cf11c1", "3ad440e371906b2fa4bc2ec4ae5c430267cf11c1",
[] []

14
tests/wpt/tests/css/css-overflow/overflow-body-propagation-012-ref.html vendored Normal file
View file

@ -0,0 +1,14 @@
<!doctype html>
<html><head>
<meta charset="utf-8">
<title>CSS Reference: BODY with overflow:hidden</title>
<link rel="author" title="Oriol Brufau" href="mailto:obrufau@igalia.com">
<style>
div {
width: 400px;
height: 400px;
background: green;
}
</style></head>
<body><div></div></body>
</html>

30
tests/wpt/tests/css/css-overflow/overflow-body-propagation-012.html vendored Normal file
View file

@ -0,0 +1,30 @@
<!doctype html>
<html><head>
<meta charset="utf-8">
<title>CSS Test: BODY with overflow:hidden</title>
<link rel="author" title="Oriol Brufau" href="mailto:obrufau@igalia.com">
<link rel="help" href="https://github.com/servo/servo/issues/38799">
<meta name="assert" content="The overflow value that gets propagated to
the viewport is the one of the <html>, not the <body>.
Therefore, the <body> is able to hide its overflowing contents.">
<link rel="match" href="overflow-body-propagation-012-ref.html">
<style>
html {
overflow: hidden;
height: 500px;
}
body {
overflow: hidden;
width: 0px;
height: 0px;
border: solid 200px green;
}
div {
background: red;
height: 200px;
width: 200px;
}
</style></head>
<body><div></div></body>
</html>