Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy fixes regarding clone_from (#32482)

Browse source
This commit is contained in:
Peter Mikola 2024-06-12 19:09:56 +02:00 • committed by GitHub
parent fd472ebd0e
commit 0a641816bf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 35 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/dedicatedworkerglobalscope.rs
View file

@ -86,7 +86,10 @@ impl<'a> AutoWorkerReset<'a> {
impl<'a> Drop for AutoWorkerReset<'a> {
fn drop(&mut self) {
*self.workerscope.worker.borrow_mut() = self.old_worker.clone();
self.workerscope
.worker
.borrow_mut()
.clone_from(&self.old_worker)
}
}

4
components/script/dom/htmlimageelement.rs
View file

@ -954,7 +954,9 @@ impl HTMLImageElement {
};
// Step 5
*self.last_selected_source.borrow_mut() = selected_source.clone();
self.last_selected_source
.borrow_mut()
.clone_from(&selected_source);
// Step 6, check the list of available images
if let Some(src) = selected_source {

5
components/script/dom/mutationobserver.rs
View file

@ -324,7 +324,10 @@ impl MutationObserverMethods for MutationObserver {
registered.options.character_data_old_value = character_data_old_value;
registered.options.child_list = child_list;
registered.options.subtree = subtree;
registered.options.attribute_filter = attribute_filter.clone();
registered
.options
.attribute_filter
.clone_from(&attribute_filter);
replaced = true;
}
!replaced

12
components/script/dom/response.rs
View file

@ -336,9 +336,15 @@ impl ResponseMethods for Response {
// only store the relevant fields, and only clone them here
*new_response.response_type.borrow_mut() = *self.response_type.borrow();
*new_response.status.borrow_mut() = *self.status.borrow();
*new_response.raw_status.borrow_mut() = self.raw_status.borrow().clone();
*new_response.url.borrow_mut() = self.url.borrow().clone();
*new_response.url_list.borrow_mut() = self.url_list.borrow().clone();
new_response
.raw_status
.borrow_mut()
.clone_from(&self.raw_status.borrow());
new_response.url.borrow_mut().clone_from(&self.url.borrow());
new_response
.url_list
.borrow_mut()
.clone_from(&self.url_list.borrow());
if let Some(stream) = self.body_stream.get().clone() {
new_response.body_stream.set(Some(&*stream));

2
components/script/dom/webglframebuffer.rs
View file

@ -961,7 +961,7 @@ impl WebGLFramebuffer {
return Err(WebGLError::InvalidOperation);
}
*self.color_draw_buffers.borrow_mut() = buffers.clone();
self.color_draw_buffers.borrow_mut().clone_from(&buffers);
context.send_command(WebGLCommand::DrawBuffers(buffers));
Ok(())
}