mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
clippy fixes regarding clone_from (#32482)
This commit is contained in:
parent
fd472ebd0e
commit
0a641816bf
12 changed files with 35 additions and 19 deletions
|
@ -86,7 +86,10 @@ impl<'a> AutoWorkerReset<'a> {
|
|||
|
||||
impl<'a> Drop for AutoWorkerReset<'a> {
|
||||
fn drop(&mut self) {
|
||||
*self.workerscope.worker.borrow_mut() = self.old_worker.clone();
|
||||
self.workerscope
|
||||
.worker
|
||||
.borrow_mut()
|
||||
.clone_from(&self.old_worker)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -954,7 +954,9 @@ impl HTMLImageElement {
|
|||
};
|
||||
|
||||
// Step 5
|
||||
*self.last_selected_source.borrow_mut() = selected_source.clone();
|
||||
self.last_selected_source
|
||||
.borrow_mut()
|
||||
.clone_from(&selected_source);
|
||||
|
||||
// Step 6, check the list of available images
|
||||
if let Some(src) = selected_source {
|
||||
|
|
|
@ -324,7 +324,10 @@ impl MutationObserverMethods for MutationObserver {
|
|||
registered.options.character_data_old_value = character_data_old_value;
|
||||
registered.options.child_list = child_list;
|
||||
registered.options.subtree = subtree;
|
||||
registered.options.attribute_filter = attribute_filter.clone();
|
||||
registered
|
||||
.options
|
||||
.attribute_filter
|
||||
.clone_from(&attribute_filter);
|
||||
replaced = true;
|
||||
}
|
||||
!replaced
|
||||
|
|
|
@ -336,9 +336,15 @@ impl ResponseMethods for Response {
|
|||
// only store the relevant fields, and only clone them here
|
||||
*new_response.response_type.borrow_mut() = *self.response_type.borrow();
|
||||
*new_response.status.borrow_mut() = *self.status.borrow();
|
||||
*new_response.raw_status.borrow_mut() = self.raw_status.borrow().clone();
|
||||
*new_response.url.borrow_mut() = self.url.borrow().clone();
|
||||
*new_response.url_list.borrow_mut() = self.url_list.borrow().clone();
|
||||
new_response
|
||||
.raw_status
|
||||
.borrow_mut()
|
||||
.clone_from(&self.raw_status.borrow());
|
||||
new_response.url.borrow_mut().clone_from(&self.url.borrow());
|
||||
new_response
|
||||
.url_list
|
||||
.borrow_mut()
|
||||
.clone_from(&self.url_list.borrow());
|
||||
|
||||
if let Some(stream) = self.body_stream.get().clone() {
|
||||
new_response.body_stream.set(Some(&*stream));
|
||||
|
|
|
@ -961,7 +961,7 @@ impl WebGLFramebuffer {
|
|||
return Err(WebGLError::InvalidOperation);
|
||||
}
|
||||
|
||||
*self.color_draw_buffers.borrow_mut() = buffers.clone();
|
||||
self.color_draw_buffers.borrow_mut().clone_from(&buffers);
|
||||
context.send_command(WebGLCommand::DrawBuffers(buffers));
|
||||
Ok(())
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue