mirror of
https://github.com/servo/servo.git
synced 2025-07-01 04:23:39 +01:00
style: Use a consistent style for position shorthand parsing.
This commit is contained in:
parent
725943f383
commit
0a87a15d23
1 changed files with 32 additions and 18 deletions
|
@ -52,15 +52,19 @@
|
||||||
use values::specified::NonNegativeNumber;
|
use values::specified::NonNegativeNumber;
|
||||||
use properties::longhands::flex_basis::SpecifiedValue as FlexBasis;
|
use properties::longhands::flex_basis::SpecifiedValue as FlexBasis;
|
||||||
|
|
||||||
fn parse_flexibility<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
fn parse_flexibility<'i, 't>(
|
||||||
-> Result<(NonNegativeNumber, Option<NonNegativeNumber>),ParseError<'i>> {
|
context: &ParserContext,
|
||||||
|
input: &mut Parser<'i, 't>,
|
||||||
|
) -> Result<(NonNegativeNumber, Option<NonNegativeNumber>),ParseError<'i>> {
|
||||||
let grow = NonNegativeNumber::parse(context, input)?;
|
let grow = NonNegativeNumber::parse(context, input)?;
|
||||||
let shrink = input.try(|i| NonNegativeNumber::parse(context, i)).ok();
|
let shrink = input.try(|i| NonNegativeNumber::parse(context, i)).ok();
|
||||||
Ok((grow, shrink))
|
Ok((grow, shrink))
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn parse_value<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
pub fn parse_value<'i, 't>(
|
||||||
-> Result<Longhands, ParseError<'i>> {
|
context: &ParserContext,
|
||||||
|
input: &mut Parser<'i, 't>,
|
||||||
|
) -> Result<Longhands, ParseError<'i>> {
|
||||||
let mut grow = None;
|
let mut grow = None;
|
||||||
let mut shrink = None;
|
let mut shrink = None;
|
||||||
let mut basis = None;
|
let mut basis = None;
|
||||||
|
@ -144,8 +148,10 @@
|
||||||
// NOTE: Since both the shorthands have the same code, we should (re-)use code from one to implement
|
// NOTE: Since both the shorthands have the same code, we should (re-)use code from one to implement
|
||||||
// the other. This might not be a big deal for now, but we should consider looking into this in the future
|
// the other. This might not be a big deal for now, but we should consider looking into this in the future
|
||||||
// to limit the amount of code generated.
|
// to limit the amount of code generated.
|
||||||
pub fn parse_value<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
pub fn parse_value<'i, 't>(
|
||||||
-> Result<Longhands, ParseError<'i>> {
|
context: &ParserContext,
|
||||||
|
input: &mut Parser<'i, 't>,
|
||||||
|
) -> Result<Longhands, ParseError<'i>> {
|
||||||
let start = input.try(|i| GridLine::parse(context, i))?;
|
let start = input.try(|i| GridLine::parse(context, i))?;
|
||||||
let end = if input.try(|i| i.expect_delim('/')).is_ok() {
|
let end = if input.try(|i| i.expect_delim('/')).is_ok() {
|
||||||
GridLine::parse(context, input)?
|
GridLine::parse(context, input)?
|
||||||
|
@ -182,8 +188,10 @@
|
||||||
use parser::Parse;
|
use parser::Parse;
|
||||||
|
|
||||||
// The code is the same as `grid-{row,column}` except that this can have four values at most.
|
// The code is the same as `grid-{row,column}` except that this can have four values at most.
|
||||||
pub fn parse_value<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
pub fn parse_value<'i, 't>(
|
||||||
-> Result<Longhands, ParseError<'i>> {
|
context: &ParserContext,
|
||||||
|
input: &mut Parser<'i, 't>,
|
||||||
|
) -> Result<Longhands, ParseError<'i>> {
|
||||||
fn line_with_ident_from(other: &GridLine) -> GridLine {
|
fn line_with_ident_from(other: &GridLine) -> GridLine {
|
||||||
let mut this = GridLine::auto();
|
let mut this = GridLine::auto();
|
||||||
if other.line_num.is_none() && !other.is_span {
|
if other.line_num.is_none() && !other.is_span {
|
||||||
|
@ -253,10 +261,10 @@
|
||||||
use values::specified::position::{TemplateAreas, TemplateAreasArc};
|
use values::specified::position::{TemplateAreas, TemplateAreasArc};
|
||||||
|
|
||||||
/// Parsing for `<grid-template>` shorthand (also used by `grid` shorthand).
|
/// Parsing for `<grid-template>` shorthand (also used by `grid` shorthand).
|
||||||
pub fn parse_grid_template<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
pub fn parse_grid_template<'i, 't>(
|
||||||
-> Result<(GridTemplateComponent,
|
context: &ParserContext,
|
||||||
GridTemplateComponent,
|
input: &mut Parser<'i, 't>,
|
||||||
Either<TemplateAreasArc, None_>), ParseError<'i>> {
|
) -> Result<(GridTemplateComponent, GridTemplateComponent, Either<TemplateAreasArc, None_>), ParseError<'i>> {
|
||||||
// Other shorthand sub properties also parse `none` and `subgrid` keywords and this
|
// Other shorthand sub properties also parse `none` and `subgrid` keywords and this
|
||||||
// shorthand should know after these keywords there is nothing to parse. Otherwise it
|
// shorthand should know after these keywords there is nothing to parse. Otherwise it
|
||||||
// gets confused and rejects the sub properties that contains `none` or `subgrid`.
|
// gets confused and rejects the sub properties that contains `none` or `subgrid`.
|
||||||
|
@ -354,8 +362,10 @@
|
||||||
}
|
}
|
||||||
|
|
||||||
#[inline]
|
#[inline]
|
||||||
pub fn parse_value<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
pub fn parse_value<'i, 't>(
|
||||||
-> Result<Longhands, ParseError<'i>> {
|
context: &ParserContext,
|
||||||
|
input: &mut Parser<'i, 't>,
|
||||||
|
) -> Result<Longhands, ParseError<'i>> {
|
||||||
let (rows, columns, areas) = parse_grid_template(context, input)?;
|
let (rows, columns, areas) = parse_grid_template(context, input)?;
|
||||||
Ok(expanded! {
|
Ok(expanded! {
|
||||||
grid_template_rows: rows,
|
grid_template_rows: rows,
|
||||||
|
@ -481,8 +491,10 @@
|
||||||
use values::specified::{GenericGridTemplateComponent, TrackSize};
|
use values::specified::{GenericGridTemplateComponent, TrackSize};
|
||||||
use values::specified::position::{AutoFlow, GridAutoFlow};
|
use values::specified::position::{AutoFlow, GridAutoFlow};
|
||||||
|
|
||||||
pub fn parse_value<'i, 't>(context: &ParserContext, input: &mut Parser<'i, 't>)
|
pub fn parse_value<'i, 't>(
|
||||||
-> Result<Longhands, ParseError<'i>> {
|
context: &ParserContext,
|
||||||
|
input: &mut Parser<'i, 't>,
|
||||||
|
) -> Result<Longhands, ParseError<'i>> {
|
||||||
let mut temp_rows = GridTemplateComponent::None;
|
let mut temp_rows = GridTemplateComponent::None;
|
||||||
let mut temp_cols = GridTemplateComponent::None;
|
let mut temp_cols = GridTemplateComponent::None;
|
||||||
let mut temp_areas = Either::Second(None_);
|
let mut temp_areas = Either::Second(None_);
|
||||||
|
@ -490,8 +502,10 @@
|
||||||
let mut auto_cols = TrackSize::default();
|
let mut auto_cols = TrackSize::default();
|
||||||
let mut flow = grid_auto_flow::get_initial_value();
|
let mut flow = grid_auto_flow::get_initial_value();
|
||||||
|
|
||||||
fn parse_auto_flow<'i, 't>(input: &mut Parser<'i, 't>, is_row: bool)
|
fn parse_auto_flow<'i, 't>(
|
||||||
-> Result<GridAutoFlow, ParseError<'i>> {
|
input: &mut Parser<'i, 't>,
|
||||||
|
is_row: bool,
|
||||||
|
) -> Result<GridAutoFlow, ParseError<'i>> {
|
||||||
let mut auto_flow = None;
|
let mut auto_flow = None;
|
||||||
let mut dense = false;
|
let mut dense = false;
|
||||||
for _ in 0..2 {
|
for _ in 0..2 {
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue