From 0a8b69879a849a5ad9af2066076343232b0c18b7 Mon Sep 17 00:00:00 2001 From: Mukilan Thiyagarajan Date: Fri, 23 Feb 2024 20:25:00 +0530 Subject: [PATCH] ci: Fix nightly release action (#31420) * ci: check result of dependent jobs explicitly Signed-off-by: Mukilan Thiyagarajan * ci: use ubuntu latest image in more jobs Signed-off-by: Mukilan Thiyagarajan --------- Signed-off-by: Mukilan Thiyagarajan --- .github/workflows/nightly.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 42b1a027ec8..04aace01f52 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -15,7 +15,7 @@ jobs: # This job is only useful when run on upstream servo. if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch' name: Create Draft GH Release - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest steps: - id: create-release run: | @@ -43,10 +43,10 @@ jobs: # This job is only useful when run on upstream servo. if: always() && (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch') name: Publish GH Release for nightly - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest steps: - name: Publish as latest (success) - if: success() + if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }} run: | gh api \ --method PATCH \ @@ -55,7 +55,7 @@ jobs: /repos/${NIGHTLY_REPO}/releases/${RELEASE_ID} \ -F draft=false - name: Publish as latest (failure) - if: failure() + if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }} run: | gh api \ --method PATCH \