From 0b593759df4e3597a9fc52fdfb08f0581e19340f Mon Sep 17 00:00:00 2001 From: Saurav Sachidanand Date: Wed, 16 Mar 2016 22:20:22 +0530 Subject: [PATCH] Resets selection in textinput when its content is changed. Adds a wpt test as well. --- components/script/textinput.rs | 1 + tests/wpt/metadata/MANIFEST.json | 11 ++++++++++- .../selection-after-content-change.html | 18 ++++++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html diff --git a/components/script/textinput.rs b/components/script/textinput.rs index f407592a0ef..35b49ee57a4 100644 --- a/components/script/textinput.rs +++ b/components/script/textinput.rs @@ -497,6 +497,7 @@ impl TextInput { }; self.edit_point.line = min(self.edit_point.line, self.lines.len() - 1); self.edit_point.index = min(self.edit_point.index, self.current_line_length()); + self.selection_begin = None; } pub fn get_absolute_insertion_point(&self) -> usize { diff --git a/tests/wpt/metadata/MANIFEST.json b/tests/wpt/metadata/MANIFEST.json index 996d1204996..6932cb31acb 100644 --- a/tests/wpt/metadata/MANIFEST.json +++ b/tests/wpt/metadata/MANIFEST.json @@ -34784,7 +34784,16 @@ }, "local_changes": { "deleted": [], - "items": {}, + "items": { + "testharness": { + "html/semantics/forms/textfieldselection/selection-after-content-change.html": [ + { + "path": "html/semantics/forms/textfieldselection/selection-after-content-change.html", + "url": "/html/semantics/forms/textfieldselection/selection-after-content-change.html" + } + ] + } + }, "reftest_nodes": {} }, "reftest_nodes": { diff --git a/tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html b/tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html new file mode 100644 index 00000000000..90ebc28a238 --- /dev/null +++ b/tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html @@ -0,0 +1,18 @@ + + +Selection indices after content change + + +