Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-29 17:18:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

webdriver: Focus when "switch to window" (#38889)

Browse source 
Add logic that was accidentally removed in #38745. Otherwise it is very
weird when using webdriver as a human, as we still stays on the original
tab.

Testing: ~this should not affect any test. Even if the tab is not
"visible" previously, all programmatic interaction works fine.~ Stably
pass `test_history_pushstate` in `back.py` and `forward.py`.

---------

Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
This commit is contained in:
Euclid Ye 2025-08-24 21:36:58 +08:00 • committed by GitHub
parent 71db9494bb
commit 0b5bcfbf17
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/webdriver_server/lib.rs
View file

@ -1067,7 +1067,7 @@ impl Handler {
/// <https://w3c.github.io/webdriver/#get-window-handles> /// <https://w3c.github.io/webdriver/#get-window-handles>
fn handle_window_handles(&mut self) -> WebDriverResult<WebDriverResponse> { fn handle_window_handles(&mut self) -> WebDriverResult<WebDriverResponse> {
let mut handles = self.get_window_handles(); let mut handles = self.get_window_handles();
handles.sort(); handles.sort_unstable();
Ok(WebDriverResponse::Generic(ValueResponse( Ok(WebDriverResponse::Generic(ValueResponse(
serde_json::to_value(handles)?, serde_json::to_value(handles)?,
@ -1266,6 +1266,12 @@ impl Handler {
let session = self.session_mut()?; let session = self.session_mut()?;
session.set_webview_id(webview_id); session.set_webview_id(webview_id);
session.set_browsing_context_id(BrowsingContextId::from(webview_id)); session.set_browsing_context_id(BrowsingContextId::from(webview_id));
// Step 5. Update any implementation-specific state that would result
// from the user selecting session's current browsing context for interaction,
// without altering OS-level focus.
self.focus_webview(webview_id)?;
Ok(WebDriverResponse::Void) Ok(WebDriverResponse::Void)
} }

3
tests/wpt/meta/webdriver/tests/classic/back/back.py.ini vendored
View file

@ -7,6 +7,3 @@
[test_seen_nodes[https coop\]] [test_seen_nodes[https coop\]]
expected: FAIL expected: FAIL
[test_history_pushstate]
expected: FAIL

3
tests/wpt/meta/webdriver/tests/classic/forward/forward.py.ini vendored
View file

@ -13,6 +13,3 @@
[test_removed_iframe] [test_removed_iframe]
expected: FAIL expected: FAIL
[test_history_pushstate]
expected: FAIL