From 0bef4ed35c5c9a343cae96502c3ef846b4bd132f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20W=C3=BClker?= <simon.wuelker@arcor.de>
Date: Mon, 2 Jun 2025 01:56:48 +0200
Subject: [PATCH] Add web platform test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
---
 components/script/dom/element.rs              |  2 +-
 components/script/dom/htmlhrelement.rs        |  4 +--
 tests/wpt/meta/MANIFEST.json                  | 34 +++++++++++++++++++
 .../the-hr-element-0/size-ref.html            | 20 +++++++++++
 .../size-with-color-or-noshade-ref.html       | 17 ++++++++++
 .../size-with-color-or-noshade.html           | 15 ++++++++
 .../the-hr-element-0/size.html                | 13 +++++++
 7 files changed, 102 insertions(+), 3 deletions(-)
 create mode 100644 tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-ref.html
 create mode 100644 tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade-ref.html
 create mode 100644 tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade.html
 create mode 100644 tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size.html

diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs
index 931901117be..3ca65b678d4 100644
--- a/components/script/dom/element.rs
+++ b/components/script/dom/element.rs
@@ -1307,7 +1307,7 @@ impl<'dom> LayoutElementHelpers<'dom> for LayoutDom<'dom, Element> {
             ));
         }
 
-        // https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2
+        // https://html.spec.whatwg.org/multipage/#the-hr-element-2
         if let Some(size_info) = self
             .downcast::<HTMLHRElement>()
             .and_then(|hr_element| hr_element.get_size_info())
diff --git a/components/script/dom/htmlhrelement.rs b/components/script/dom/htmlhrelement.rs
index 8cf281c090b..8dc11e4e848 100644
--- a/components/script/dom/htmlhrelement.rs
+++ b/components/script/dom/htmlhrelement.rs
@@ -92,7 +92,7 @@ impl HTMLHRElementMethods<crate::DomTypeHolder> for HTMLHRElement {
 
 /// The result of applying the the presentational hint for the `size` attribute.
 ///
-/// (This attribute can mean different things depending on it's value and other attributes)
+/// (This attribute can mean different things depending on its value and other attributes)
 #[allow(clippy::enum_variant_names)]
 pub(crate) enum SizePresentationalHint {
     SetHeightTo(Size),
@@ -123,7 +123,7 @@ impl HTMLHRLayoutHelpers for LayoutDom<'_, HTMLHRElement> {
     }
 
     fn get_size_info(self) -> Option<SizePresentationalHint> {
-        // https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2
+        // https://html.spec.whatwg.org/multipage/#the-hr-element-2
         let element = self.upcast::<Element>();
         let size_value = element
             .get_attr_val_for_layout(&ns!(), &local_name!("size"))
diff --git a/tests/wpt/meta/MANIFEST.json b/tests/wpt/meta/MANIFEST.json
index bb64cbc3810..c844af00cee 100644
--- a/tests/wpt/meta/MANIFEST.json
+++ b/tests/wpt/meta/MANIFEST.json
@@ -351498,6 +351498,32 @@
          {}
         ]
        ],
+       "size-with-color-or-noshade.html": [
+        "db1d583934e6df482cde846eda757e010e7d0310",
+        [
+         null,
+         [
+          [
+           "/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade-ref.html",
+           "=="
+          ]
+         ],
+         {}
+        ]
+       ],
+       "size.html": [
+        "2162131b853ed77917ab373f4fb2c70c536e453c",
+        [
+         null,
+         [
+          [
+           "/html/rendering/non-replaced-elements/the-hr-element-0/size-ref.html",
+           "=="
+          ]
+         ],
+         {}
+        ]
+       ],
        "width.html": [
         "a436d2ae25a6b03f320bda066f32c374b84e0d92",
         [
@@ -479883,6 +479909,14 @@
         "5cd35c83ada3470ad7a16d14a5028b01596bb60c",
         []
        ],
+       "size-ref.html": [
+        "03a21eb45737ef46247d8bdd61fe5ea0dcefef3e",
+        []
+       ],
+       "size-with-color-or-noshade-ref.html": [
+        "d6300e250d97d113e9ef358daa300de4bd593850",
+        []
+       ],
        "width-ref.html": [
         "71e7651c1ab6927f1be436ef8ff749f920924562",
         []
diff --git a/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-ref.html b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-ref.html
new file mode 100644
index 00000000000..03a21eb4573
--- /dev/null
+++ b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-ref.html
@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+        #foo {
+            height: 50px;
+            box-sizing: border-box;
+        }
+        #bar {
+            border-bottom-width: 0px;
+            box-sizing: border-box;
+        }
+    </style>
+</head>
+<body>
+    <hr id="foo">
+    <hr id="bar">
+</body>
+</html>
+
diff --git a/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade-ref.html b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade-ref.html
new file mode 100644
index 00000000000..d6300e250d9
--- /dev/null
+++ b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade-ref.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+        hr {
+            border-width: 25px;
+        }
+    </style>
+</head>
+<body>
+    <hr color="black">
+    <hr color="totally-not-a-color">
+    <hr noshade>
+    <hr color="black" noshade>
+</body>
+</html>
+
diff --git a/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade.html b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade.html
new file mode 100644
index 00000000000..db1d583934e
--- /dev/null
+++ b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade.html
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+<link rel="help" href="https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2" />
+<title>hr elements: Tests behaviour of a size attribute with color/noshade attributes present</title>
+<link rel="author" title="Simon Wülker" href="mailto:simon.wuelker@arcor.de">
+<link rel="match" href="/html/rendering/non-replaced-elements/the-hr-element-0/size-with-color-or-noshade-ref.html">
+<meta name="assert" content="This checks that the size attribute of a hr element changes the border widths when color/noshade attributes are present">
+<body>
+    <hr size=50 color="black">
+    <hr size=50 color="totally-not-a-color">
+    <hr size=50 noshade>
+    <hr size=50 color="black" noshade>
+</body>
+</html>
+
diff --git a/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size.html b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size.html
new file mode 100644
index 00000000000..2162131b853
--- /dev/null
+++ b/tests/wpt/tests/html/rendering/non-replaced-elements/the-hr-element-0/size.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<html>
+<link rel="help" href="https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2" />
+<title>hr elements: Tests behaviour of a size attribute without color/noshade attributes</title>
+<link rel="author" title="Simon Wülker" href="mailto:simon.wuelker@arcor.de">
+<link rel="match" href="/html/rendering/non-replaced-elements/the-hr-element-0/size-ref.html">
+<meta name="assert" content="This checks that the size attribute of a hr element changes its height.">
+<body>
+    <hr size=50>
+    <hr size=1>
+</body>
+</html>
+