From 0bf8676345615baacbd1c925b316b4b3c98f6184 Mon Sep 17 00:00:00 2001
From: Martin Robinson <mrobinson@igalia.com>
Date: Tue, 5 Aug 2025 13:07:42 +0200
Subject: [PATCH] layout: Cache projected point in spatial node when hit
 testing (#38464)

Implement a simple one element cache for projected points in spatial
nodes. This should reduce the amount matrix math done during hit
testing.

Testing: This should not change test results, but should improve
performance a bit. Thus, tests are not necessary beyond existing
performance tests.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
---
 components/layout/display_list/hit_test.rs | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/components/layout/display_list/hit_test.rs b/components/layout/display_list/hit_test.rs
index ffdc31e069b..2cffc7d1f30 100644
--- a/components/layout/display_list/hit_test.rs
+++ b/components/layout/display_list/hit_test.rs
@@ -28,6 +28,9 @@ pub(crate) struct HitTest<'a> {
     flags: ElementsFromPointFlags,
     /// The point to test for this hit test, relative to the page.
     point_to_test: LayoutPoint,
+    /// A cached version of [`Self::point_to_test`] projected to a spatial node, to avoid
+    /// doing a lot of matrix math over and over.
+    projected_point_to_test: Option<(ScrollTreeNodeId, LayoutPoint, LayoutTransform)>,
     /// The stacking context tree against which to perform the hit test.
     stacking_context_tree: &'a StackingContextTree,
     /// The resulting [`HitTestResultItems`] for this hit test.
@@ -45,6 +48,7 @@ impl<'a> HitTest<'a> {
         let mut hit_test = Self {
             flags,
             point_to_test,
+            projected_point_to_test: None,
             stacking_context_tree,
             results: Vec::new(),
             clip_hit_test_results: HashMap::new(),
@@ -80,9 +84,18 @@ impl<'a> HitTest<'a> {
     /// returning `None` if the transformation is uninvertible or the point cannot be
     /// projected into the spatial node.
     fn location_in_spatial_node(
-        &self,
+        &mut self,
         scroll_tree_node_id: ScrollTreeNodeId,
     ) -> Option<(LayoutPoint, LayoutTransform)> {
+        match self.projected_point_to_test {
+            Some((cached_scroll_tree_node_id, projected_point, transform))
+                if cached_scroll_tree_node_id == scroll_tree_node_id =>
+            {
+                return Some((projected_point, transform));
+            },
+            _ => {},
+        }
+
         let transform = self
             .stacking_context_tree
             .compositor_info
@@ -103,11 +116,10 @@ impl<'a> HitTest<'a> {
         let z =
             -(point.x * transform.m13 + point.y * transform.m23 + transform.m43) / transform.m33;
         let projected_point = transform.transform_point3d(Point3D::new(point.x, point.y, z))?;
+        let projected_point = Point2D::new(projected_point.x, projected_point.y);
 
-        Some((
-            Point2D::new(projected_point.x, projected_point.y),
-            transform,
-        ))
+        self.projected_point_to_test = Some((scroll_tree_node_id, projected_point, transform));
+        Some((projected_point, transform))
     }
 }