Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-11 16:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix table track constrainedness (#33550)

Browse source 
* Fix table track constraindness

Only as size that isn't `auto` and doesn't contain percentages can constrain
a table track (https://drafts.csswg.org/css-tables/#constrainedness).

However, in a bunch of cases we were only checking for `auto`.

Also, we were allowing the inline-size of a cell to constrain both its
column and row. Using the block-size of the row makes more sense.
The spec doesn't define constrainedness for rows, though.

Signed-off-by: Oriol Brufau <obrufau@igalia.com>

* Apply suggestions from code review

Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>

---------

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Oriol Brufau 2024-09-26 07:06:33 -07:00 • committed by GitHub
parent 1346643727
commit 0cefee48e1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 27 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/wpt/meta/css/css-tables/auto-layout-calc-width-001.html.ini vendored
View file

@ -1,3 +0,0 @@
[auto-layout-calc-width-001.html]
[#theTable 1]
expected: FAIL

3
tests/wpt/meta/css/css-tables/fixed-layout-calc-width-001.html.ini vendored
View file

@ -1,3 +0,0 @@
[fixed-layout-calc-width-001.html]
[#theTable 1]
expected: FAIL

2
tests/wpt/meta/css/css-tables/tentative/rowspan-height-redistribution.html.ini vendored
View file

@ -1,5 +1,5 @@
[rowspan-height-redistribution.html]
[table 8]
[table 17]
expected: FAIL
[table 22]

15
tests/wpt/meta/css/css-tables/tentative/table-height-redistribution.html.ini vendored
View file

@ -8,21 +8,6 @@
[table 17]
expected: FAIL
[table 18]
expected: FAIL
[table 19]
expected: FAIL
[table 20]
expected: FAIL
[table 21]
expected: FAIL
[table 22]
expected: FAIL
[table 25]
expected: FAIL

3
tests/wpt/meta/css/css-tables/visibility-collapse-row-004.html.ini vendored
View file

@ -1,3 +0,0 @@
[visibility-collapse-row-004.html]
[collapsed row shrinks table height]
expected: FAIL