Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-08 06:55:31 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix table track constrainedness (#33550)

Browse source 
* Fix table track constraindness

Only as size that isn't `auto` and doesn't contain percentages can constrain
a table track (https://drafts.csswg.org/css-tables/#constrainedness).

However, in a bunch of cases we were only checking for `auto`.

Also, we were allowing the inline-size of a cell to constrain both its
column and row. Using the block-size of the row makes more sense.
The spec doesn't define constrainedness for rows, though.

Signed-off-by: Oriol Brufau <obrufau@igalia.com>

* Apply suggestions from code review

Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>

---------

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Oriol Brufau 2024-09-26 07:06:33 -07:00 • committed by GitHub
parent 1346643727
commit 0cefee48e1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 27 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-attribute.html.ini vendored
View file

@ -122,12 +122,6 @@
[table th align attribute justify is correct]
expected: FAIL
[td height attribute pixel is correct]
expected: FAIL
[th height attribute pixel is correct]
expected: FAIL
[table_td height attribute percentage is correct]
expected: FAIL
@ -139,3 +133,6 @@
[table cellpadding attribute is correct]
expected: FAIL
[table_tr height attribute percentage is correct]
expected: FAIL