Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-12 08:55:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #9054 - frewsxcv:parse-non-zero-dimension, r=eefriedman

Browse source 
Implement non-zero dimension attribute parsing

Fixes #8445

The only attributes I found that we have implemented that uses non-zero
dimenion attributes:

* `width` for `<td>` and `<th>` (table cells)
* `width` for `<table>`

I updated these implementations to use the new non-zero dimension
attribute parsing and added associated regression tests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9054)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-12-30 05:26:56 +05:30
commit 0d52170f35
13 changed files with 227 additions and 291 deletions
Download patch file Download diff file Expand all files Collapse all files

37
tests/wpt/web-platform-tests/html/rendering/non-replaced-elements/tables/table-cell-width-ref.html Normal file
View file

@ -0,0 +1,37 @@
<style>
body {
margin: 0;
}
.row {
clear: both;
}
.row div {
float: left;
}
.red {
background-color: red;
}
</style>
<div class="row">
<div class="red" style="width: 200px">a</div>
<div style="width: 200px">a</div>
</div>
<div class="row">
<div class="red" style="width: 200px">a</div>
<div style="width: 200px">a</div>
</div>
<div class="row">
<div class="red" style="width: 100px">a</div>
<div style="width: 300px">a</div>
</div>
<div class="row">
<div class="red" style="width: 100px">a</div>
<div style="width: 300px">a</div>
</div>

54
tests/wpt/web-platform-tests/html/rendering/non-replaced-elements/tables/table-cell-width.html Normal file
View file

@ -0,0 +1,54 @@
<link rel="match" href="table-cell-width-ref.html">
<style>
body {
margin: 0;
}
table {
width: 400px;
border-collapse: collapse;
}
th {
font-weight: normal;
text-align: left;
}
td, th {
padding: 0;
}
td:first-child, th:first-child {
background-color: red;
}
</style>
<!-- width=0 should be treated as 'auto' -->
<table>
<tr>
<th width=0>a</th>
<th>a</th>
</tr>
</table>
<table>
<tr>
<td width=0>a</td>
<td>a</td>
</tr>
</table>
<!-- test valid width attribute value-->
<table>
<tr>
<th width=100>a</th>
<th>a</th>
</tr>
</table>
<table>
<tr>
<td width=100>a</td>
<td>a</td>
</tr>
</table>

13
tests/wpt/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-ref.html Normal file
View file

@ -0,0 +1,13 @@
<style>
p {
padding: 0;
margin: 0;
}
</style>
<p>a b</p>
<hr>
<p>a</p>
<p>b</p>

30
tests/wpt/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width.html Normal file
View file

@ -0,0 +1,30 @@
<link rel="match" href="table-width-ref.html">
<style>
table {
border-collapse: collapse;
}
td {
padding: 0;
}
</style>
<!-- width=0 should be treated as 'auto' -->
<table width=0>
<tr>
<td>
a b
</td>
</tr>
</table>
<hr>
<table width=1>
<tr>
<td>
a b
</td>
</tr>
</table>