Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

[NFC] Remove unused metrics code (#34370)

Browse source 
Signed-off-by: Delan Azabani <dazabani@igalia.com>
This commit is contained in:
Delan Azabani 2024-11-25 16:29:37 +08:00 • committed by GitHub
parent cb212633b6
commit 0d91da610a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

28
components/metrics/lib.rs
View file

@ -56,10 +56,9 @@ fn set_metric<U: ProgressiveWebMetric>(
metric_type: ProgressiveWebMetricType, metric_type: ProgressiveWebMetricType,
category: ProfilerCategory, category: ProfilerCategory,
attr: &Cell<Option<CrossProcessInstant>>, attr: &Cell<Option<CrossProcessInstant>>,
metric_time: Option<CrossProcessInstant>, metric_time: CrossProcessInstant,
url: &ServoUrl, url: &ServoUrl,
) { ) {
let metric_time = metric_time.unwrap_or_else(CrossProcessInstant::now);
attr.set(Some(metric_time)); attr.set(Some(metric_time));
// Queue performance observer notification. // Queue performance observer notification.
@ -211,7 +210,7 @@ impl InteractiveMetrics {
ProgressiveWebMetricType::TimeToInteractive, ProgressiveWebMetricType::TimeToInteractive,
ProfilerCategory::TimeToInteractive, ProfilerCategory::TimeToInteractive,
&self.time_to_interactive, &self.time_to_interactive,
Some(metric_time), metric_time,
&self.url, &self.url,
); );
} }
@ -285,25 +284,6 @@ impl PaintTimeMetrics {
} }
} }
pub fn maybe_set_first_paint<T>(&self, profiler_metadata_factory: &T)
where
T: ProfilerMetadataFactory,
{
if self.first_paint.get().is_some() {
return;
}
set_metric(
self,
profiler_metadata_factory.new_metadata(),
ProgressiveWebMetricType::FirstPaint,
ProfilerCategory::TimeToFirstPaint,
&self.first_paint,
None,
&self.url,
);
}
pub fn maybe_observe_paint_time<T>( pub fn maybe_observe_paint_time<T>(
&self, &self,
profiler_metadata_factory: &T, profiler_metadata_factory: &T,
@ -348,7 +328,7 @@ impl PaintTimeMetrics {
ProgressiveWebMetricType::FirstPaint, ProgressiveWebMetricType::FirstPaint,
ProfilerCategory::TimeToFirstPaint, ProfilerCategory::TimeToFirstPaint,
&self.first_paint, &self.first_paint,
Some(paint_time), paint_time,
&self.url, &self.url,
); );
@ -359,7 +339,7 @@ impl PaintTimeMetrics {
ProgressiveWebMetricType::FirstContentfulPaint, ProgressiveWebMetricType::FirstContentfulPaint,
ProfilerCategory::TimeToFirstContentfulPaint, ProfilerCategory::TimeToFirstContentfulPaint,
&self.first_contentful_paint, &self.first_contentful_paint,
Some(paint_time), paint_time,
&self.url, &self.url,
); );
} }