From 0d9b4e858c25b71e60c45e44cb86205153516ebe Mon Sep 17 00:00:00 2001 From: Pavel Potocek Date: Tue, 17 Jan 2017 18:35:49 +0100 Subject: [PATCH] Fix #14497: WeakMediaQueryListVec assumes its contents are still alive --- components/script/dom/mediaquerylist.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/script/dom/mediaquerylist.rs b/components/script/dom/mediaquerylist.rs index db96a4760cd..c6e569b5e42 100644 --- a/components/script/dom/mediaquerylist.rs +++ b/components/script/dom/mediaquerylist.rs @@ -138,7 +138,7 @@ impl WeakMediaQueryListVec { /// Evaluate media query lists and report changes /// https://drafts.csswg.org/cssom-view/#evaluate-media-queries-and-report-changes pub fn evaluate_and_report_changes(&self) { - for mql in self.cell.borrow().iter() { + self.cell.borrow_mut().update(|mql| { let mql = mql.root().unwrap(); if let MediaQueryListMatchState::Changed(_) = mql.evaluate_changes() { let event = MediaQueryListEvent::new(&mql.global(), @@ -148,7 +148,7 @@ impl WeakMediaQueryListVec { mql.Matches()); event.upcast::().fire(mql.upcast::()); } - } + }); } }