Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Support single-value <select> elements (#35684)

Browse source 
https://github.com/user-attachments/assets/9aba75ff-4190-4a85-89ed-d3f3aa53d3b0



Among other things this adds a new `EmbedderMsg::ShowSelectElementMenu`
to tell the embedder to display a select popup at the given location.

This is a draft because some small style adjustments need to be made:
* the select element should always have the width of the largest option
* the border should be part of the shadow tree

Apart from that, it's mostly ready for review.

<details><summary>HTML for demo video</summary>

```html
<html>

<body>
<select id="c" name="choice">
  <option value="first">First Value</option>
  <option value="second">Second Value</option>
  <option value="third">Third Value</option>
</select>
</body>
</html>
```
</details>

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by
`[X]` when the step is complete, and replace `___` with appropriate
data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] Part of https://github.com/servo/servo/issues/3551
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox
is checked, so that we can help you if you get stuck somewhere along the
way.-->

<!-- Pull requests that do not address these steps are welcome, but they
will require additional verification as part of the review process. -->

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-04-03 14:11:55 +02:00 • committed by GitHub
parent 6e9d01b908
commit 0e99539dab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
32 changed files with 633 additions and 151 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/wpt/meta/html/semantics/forms/the-label-element/clicking-interactive-content.html.ini vendored
View file

@ -5,15 +5,9 @@
[interactive content <input> as first child of <label>]
expected: FAIL
[interactive content <select></select> as second child under <label>]
expected: FAIL
[interactive content <iframe></iframe> as second child under <label>]
expected: FAIL
[interactive content <select></select> as first child of <label>]
expected: FAIL
[interactive content <video tabindex=""></video> as second child under <label>]
expected: FAIL
@ -32,9 +26,6 @@
[interactive content <object usemap=""></object> as second child under <label>]
expected: FAIL
[interactive content <select></select> deeply nested under <label>]
expected: FAIL
[interactive content <textarea></textarea> as first child of <label>]
expected: FAIL
@ -67,4 +58,3 @@
[interactive content <textarea></textarea> as second child under <label>]
expected: FAIL

2
tests/wpt/meta/html/semantics/forms/the-select-element/customizable-select/closed-listbox-rendering.tentative.html.ini vendored
View file

@ -1,2 +0,0 @@
[closed-listbox-rendering.tentative.html]
expected: FAIL

2
tests/wpt/meta/html/semantics/forms/the-select-element/select-marker-end-aligned.tentative.html.ini vendored
View file

@ -1,2 +0,0 @@
[select-marker-end-aligned.tentative.html]
expected: FAIL