mirror of
https://github.com/servo/servo.git
synced 2025-07-22 23:03:42 +01:00
Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that live in 'components/script/dom/bindings/*' and noticed that there were many tidy violations: unnecessary semicolons, weird spacing, unused variables, lack of license headers, etc. Considering these files are now living in our tree and mostly maintained directly by contributors of Servo (as opposed to being from upstream), I feel these files should not be excluded from our normal tidy process. This commit removes the blacklist on these files and fixes all tidy violations. I added these subdirectories to the blacklist because they appear to be maintained upstream somewhere else: * "components/script/dom/bindings/codegen/parser/*", * "components/script/dom/bindings/codegen/ply/*", Also, I added a '# noqa' comment which tells us to ignore the flake8 errors for that line. I chose to ignore this (instead of fixing it) to make the work for this commit simpler for me.
This commit is contained in:
parent
fe17067d6a
commit
0ec2375cab
8 changed files with 476 additions and 261 deletions
|
@ -1,6 +1,6 @@
|
|||
# This Source Code Form is subject to the terms of the Mozilla Public
|
||||
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
||||
# You can obtain one at http://mozilla.org/MPL/2.0/.
|
||||
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
||||
|
||||
# We do one global pass over all the WebIDL to generate our prototype enum
|
||||
# and generate information for subsequent phases.
|
||||
|
@ -9,12 +9,12 @@ import sys
|
|||
sys.path.append("./parser/")
|
||||
sys.path.append("./ply/")
|
||||
import os
|
||||
import cStringIO
|
||||
import WebIDL
|
||||
import cPickle
|
||||
from Configuration import *
|
||||
from Configuration import Configuration
|
||||
from CodegenRust import GlobalGenRoots, replaceFileIfChanged
|
||||
|
||||
|
||||
def generate_file(config, name, filename):
|
||||
root = getattr(GlobalGenRoots, name)(config)
|
||||
code = root.define()
|
||||
|
@ -24,6 +24,7 @@ def generate_file(config, name, filename):
|
|||
else:
|
||||
print "%s hasn't changed - not touching it" % (filename)
|
||||
|
||||
|
||||
def main():
|
||||
# Parse arguments.
|
||||
from optparse import OptionParser
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue