Use NotImplementedError for Python base class methods

From the Python docs:

https://docs.python.org/2/library/exceptions.html#exceptions.NotImplementedError

"In user defined base classes, abstract methods should raise this
exception when they require derived classes to override the method."
This commit is contained in:
Corey Farwell 2015-07-11 07:41:44 +09:00
parent 52e857dd7b
commit 10296e77dc

View file

@ -272,7 +272,7 @@ class CGThing():
def define(self): def define(self):
"""Produce code for a Rust file.""" """Produce code for a Rust file."""
assert(False) # Override me! raise NotImplementedError # Override me!
class CGNativePropertyHooks(CGThing): class CGNativePropertyHooks(CGThing):
@ -2134,7 +2134,7 @@ class CGAbstractMethod(CGThing):
return "\n}\n" return "\n}\n"
def definition_body(self): def definition_body(self):
assert(False) # Override me! raise NotImplementedError # Override me!
def CreateBindingJSObject(descriptor, parent=None): def CreateBindingJSObject(descriptor, parent=None):
@ -2843,7 +2843,7 @@ let global = global_object_for_js_object(JS_CALLEE(cx, vp).to_object());
return CGList([preamble, self.generate_code()]) return CGList([preamble, self.generate_code()])
def generate_code(self): def generate_code(self):
assert False # Override me raise NotImplementedError # Override me!
class CGSpecializedMethod(CGAbstractExternMethod): class CGSpecializedMethod(CGAbstractExternMethod):
@ -4538,8 +4538,7 @@ let this: *const %s = native_from_reflector::<%s>(obj);
]) ])
def generate_code(self): def generate_code(self):
# Override me raise NotImplementedError # Override me!
assert(False)
def finalizeHook(descriptor, hookName, context): def finalizeHook(descriptor, hookName, context):