Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Apply start_in_channel to destination and not source during AudioBuffer.CopyToChannel

Browse source
This commit is contained in:
Fernando Jiménez Moreno 2018-09-12 07:14:33 +02:00
parent e0e1f5f900
commit 10e8ab3892
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
components/script/dom/audiobuffer.rs
View file

@ -287,14 +287,18 @@ impl AudioBufferMethods for AudioBuffer {
return Err(Error::IndexSize); return Err(Error::IndexSize);
} }
typedarray!(in(cx) let array: Float32Array = js_channel); typedarray!(in(cx) let js_channel: Float32Array = js_channel);
if let Ok(mut array) = array { if let Ok(mut js_channel) = js_channel {
let bytes_to_copy = min(self.length - start_in_channel, source.len() as u32) as usize; let bytes_to_copy = min(self.length - start_in_channel, source.len() as u32) as usize;
let offset = start_in_channel as usize;
unsafe { unsafe {
let data = &source.as_slice()[offset..offset + bytes_to_copy]; let data = &source.as_slice()[0..bytes_to_copy];
array.update(data); // Update shared channel.
(*self.shared_channels.borrow_mut()).buffers[channel_number as usize] = data.to_vec(); let mut shared_channels = self.shared_channels.borrow_mut();
let shared_channel = shared_channels.data_chan_mut(channel_number as u8);
let (_, mut shared_channel) = shared_channel.split_at_mut(start_in_channel as usize);
shared_channel[0..bytes_to_copy].copy_from_slice(data);
// Update js channel.
js_channel.update(data);
} }
} else { } else {
return Err(Error::IndexSize); return Err(Error::IndexSize);