Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

26488 Move worklet drop implementation into single droppable member

Browse source 
Signed-off-by: Benjamin Freist <bfreist@soundhound.com>
This commit is contained in:
Benjamin Freist 2023-02-13 20:23:34 +01:00
parent aa2e1433d2
commit 10ef6cdb38
1 changed files with 18 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

29
components/script/dom/worklet.rs
View file

@ -70,13 +70,25 @@ use uuid::Uuid;
const WORKLET_THREAD_POOL_SIZE: u32 = 3;
const MIN_GC_THRESHOLD: u32 = 1_000_000;
#[derive(JSTraceable, MallocSizeOf)]
struct DroppableField {
worklet_id: WorkletId,
}
impl Drop for DroppableField {
fn drop(&mut self) {
let script_thread = ScriptThread::worklet_thread_pool();
script_thread.exit_worklet(self.worklet_id);
}
}
#[dom_struct]
/// <https://drafts.css-houdini.org/worklets/#worklet>
pub struct Worklet {
reflector: Reflector,
window: Dom<Window>,
worklet_id: WorkletId,
global_type: WorkletGlobalScopeType,
droppable_field: DroppableField,
}
impl Worklet {
@ -84,8 +96,10 @@ impl Worklet {
Worklet {
reflector: Reflector::new(),
window: Dom::from_ref(window),
worklet_id: WorkletId::new(),
global_type: global_type,
droppable_field: DroppableField {
worklet_id: WorkletId::new(),
},
}
}
@ -98,7 +112,7 @@ impl Worklet {
}
pub fn worklet_id(&self) -> WorkletId {
self.worklet_id
self.droppable_field.worklet_id
}
#[allow(dead_code)]
@ -138,7 +152,7 @@ impl WorkletMethods for Worklet {
pool.fetch_and_invoke_a_worklet_script(
global.pipeline_id(),
self.worklet_id,
self.droppable_field.worklet_id,
self.global_type,
self.window.origin().immutable().clone(),
global.api_base_url(),
@ -154,13 +168,6 @@ impl WorkletMethods for Worklet {
}
}
impl Drop for Worklet {
fn drop(&mut self) {
let script_thread = ScriptThread::worklet_thread_pool();
script_thread.exit_worklet(self.worklet_id);
}
}
/// A guid for worklets.
#[derive(Clone, Copy, Debug, Eq, Hash, JSTraceable, PartialEq)]
pub struct WorkletId(Uuid);