Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make property descriptors hold named/indexed property values

Browse source
This commit is contained in:
Patrick Shaughnessy 2020-01-06 14:20:51 -05:00
parent 1d645f3741
commit 111ede9c77
8 changed files with 6 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/bindings/codegen/CodegenRust.py
View file

@ -5147,8 +5147,7 @@ class CGDOMJSProxyHandler_getOwnPropertyDescriptor(CGAbstractExternMethod):
attrs = "JSPROP_ENUMERATE" attrs = "JSPROP_ENUMERATE"
if self.descriptor.operations['IndexedSetter'] is None: if self.descriptor.operations['IndexedSetter'] is None:
attrs += " | JSPROP_READONLY" attrs += " | JSPROP_READONLY"
# FIXME(#11868) Should assign to desc.value, desc.get() is a copy. fillDescriptor = ("desc.value = result_root.get();\n"
fillDescriptor = ("desc.get().value = result_root.get();\n"
"fill_property_descriptor(MutableHandle::from_raw(desc), proxy.get(), (%s) as u32);\n" "fill_property_descriptor(MutableHandle::from_raw(desc), proxy.get(), (%s) as u32);\n"
"return true;" % attrs) "return true;" % attrs)
templateValues = { templateValues = {
@ -5173,8 +5172,7 @@ class CGDOMJSProxyHandler_getOwnPropertyDescriptor(CGAbstractExternMethod):
attrs = " | ".join(attrs) attrs = " | ".join(attrs)
else: else:
attrs = "0" attrs = "0"
# FIXME(#11868) Should assign to desc.value, desc.get() is a copy. fillDescriptor = ("desc.value = result_root.get();\n"
fillDescriptor = ("desc.get().value = result_root.get();\n"
"fill_property_descriptor(MutableHandle::from_raw(desc), proxy.get(), (%s) as u32);\n" "fill_property_descriptor(MutableHandle::from_raw(desc), proxy.get(), (%s) as u32);\n"
"return true;" % attrs) "return true;" % attrs)
templateValues = { templateValues = {
@ -5221,7 +5219,7 @@ if !expando.is_null() {
} }
} }
""" + namedGet + """\ """ + namedGet + """\
desc.get().obj = ptr::null_mut(); desc.obj = ptr::null_mut();
return true;""" return true;"""
def definition_body(self): def definition_body(self):

2
components/script/dom/webidls/HTMLFormElement.webidl
View file

@ -3,7 +3,7 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
// https://html.spec.whatwg.org/multipage/#htmlformelement // https://html.spec.whatwg.org/multipage/#htmlformelement
[Exposed=Window] [Exposed=Window, LegacyUnenumerableNamedProperties]
interface HTMLFormElement : HTMLElement { interface HTMLFormElement : HTMLElement {
[HTMLConstructor] constructor(); [HTMLConstructor] constructor();

2
components/script/dom/webidls/Window.webidl
View file

@ -3,7 +3,7 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
// https://html.spec.whatwg.org/multipage/#window // https://html.spec.whatwg.org/multipage/#window
[Global=Window, Exposed=Window] [Global=Window, Exposed=Window /*, LegacyUnenumerableNamedProperties */]
/*sealed*/ interface Window : GlobalScope { /*sealed*/ interface Window : GlobalScope {
// the current browsing context // the current browsing context
[Unforgeable] readonly attribute WindowProxy window; [Unforgeable] readonly attribute WindowProxy window;

3
components/script/dom/windowproxy.rs
View file

@ -822,8 +822,7 @@ unsafe extern "C" fn getOwnPropertyDescriptor(
assert!(desc.obj.is_null() || desc.obj == target.get()); assert!(desc.obj.is_null() || desc.obj == target.get());
if desc.obj == target.get() { if desc.obj == target.get() {
// FIXME(#11868) Should assign to desc.obj, desc.get() is a copy. desc.obj = proxy.get();
desc.get().obj = proxy.get();
} }
true true

9
tests/wpt/metadata/WebIDL/ecmascript-binding/legacy-platform-object.html.ini
View file

@ -1,14 +1,5 @@
[legacy-platform-object.html] [legacy-platform-object.html]
type: testharness type: testharness
[[[GetOwnProperty\]\] with getters and no setters]
expected: FAIL
[[[GetOwnProperty\]\] with named property getters and setters]
expected: FAIL
[[[GetOwnProperty\]\] with indexed property getters and setters]
expected: FAIL
[Test [[DefineOwnProperty\]\] with no indexed property setter support.] [Test [[DefineOwnProperty\]\] with no indexed property setter support.]
expected: FAIL expected: FAIL

3
tests/wpt/metadata/dom/collections/HTMLCollection-supported-property-indices.html.ini
View file

@ -6,6 +6,3 @@
[Trying to set an expando with an indexed property name past the end of the list] [Trying to set an expando with an indexed property name past the end of the list]
expected: FAIL expected: FAIL
[Trying to delete an indexed property name should never work]
expected: FAIL

6
tests/wpt/metadata/html/dom/elements/global-attributes/dataset-binding.window.js.ini
View file

@ -5,9 +5,3 @@
[Setting property for key 9 with accessor property on prototype] [Setting property for key 9 with accessor property on prototype]
expected: FAIL expected: FAIL
[Getting property descriptor for key 9]
expected: FAIL
[Getting property descriptor for key x]
expected: FAIL

3
tests/wpt/metadata/html/semantics/forms/the-form-element/form-nameditem.html.ini
View file

@ -1,8 +1,5 @@
[form-nameditem.html] [form-nameditem.html]
type: testharness type: testharness
[Name for a single element should work]
expected: FAIL
[All listed elements except input type=image should be present in the form] [All listed elements except input type=image should be present in the form]
expected: FAIL expected: FAIL