Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix some XHR warnings

Browse source
This commit is contained in:
Manish Goregaokar 2014-05-21 10:27:55 +05:30
parent 28e3c17340
commit 114d2e3565
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/components/script/dom/xmlhttprequest.rs
View file

@ -41,7 +41,7 @@ use RequestHeaderCollection = http::headers::request::HeaderCollection;
// As send() start accepting more and more parameter types, // As send() start accepting more and more parameter types,
// change this to the appropriate type from UnionTypes, eg // change this to the appropriate type from UnionTypes, eg
// use SendParam = dom::bindings::codegen::UnionTypes::StringOrFormData; // use SendParam = dom::bindings::codegen::UnionTypes::StringOrFormData;
type SendParam = DOMString; pub type SendParam = DOMString;
#[deriving(Eq,Encodable)] #[deriving(Eq,Encodable)]
pub enum XMLHttpRequestId { pub enum XMLHttpRequestId {
@ -310,7 +310,7 @@ impl<'a> XMLHttpRequestMethods<'a> for JSRef<'a, XMLHttpRequest> {
return Err(InvalidState); // Step 1, 2 return Err(InvalidState); // Step 1, 2
} }
let data = match self.request_method.to_lower().as_str() { let _data = match self.request_method.to_lower().as_str() {
Some("get") | Some("head") => None, // Step 3 Some("get") | Some("head") => None, // Step 3
_ => data _ => data
}; };
@ -328,12 +328,12 @@ impl<'a> XMLHttpRequestMethods<'a> for JSRef<'a, XMLHttpRequest> {
if self.sync { if self.sync {
return XMLHttpRequest::fetch(&mut Sync(self), resource_task, url); return XMLHttpRequest::fetch(&mut Sync(self), resource_task, url);
} else { } else {
let mut builder = task::task().named("XHRTask"); let builder = task::task().named("XHRTask");
unsafe { unsafe {
let addr = self.to_trusted(); let addr = self.to_trusted();
let script_chan = global.script_chan.clone(); let script_chan = global.script_chan.clone();
builder.spawn(proc() { builder.spawn(proc() {
XMLHttpRequest::fetch(&mut Async(addr, script_chan), resource_task, url); let _ = XMLHttpRequest::fetch(&mut Async(addr, script_chan), resource_task, url);
}) })
} }
} }
@ -351,12 +351,12 @@ impl<'a> XMLHttpRequestMethods<'a> for JSRef<'a, XMLHttpRequest> {
fn StatusText(&self) -> ByteString { fn StatusText(&self) -> ByteString {
self.status_text.clone() self.status_text.clone()
} }
fn GetResponseHeader(&self, name: ByteString) -> Option<ByteString> { fn GetResponseHeader(&self, _name: ByteString) -> Option<ByteString> {
None None
} }
fn GetAllResponseHeaders(&self) -> ByteString { fn GetAllResponseHeaders(&self) -> ByteString {
let mut writer = MemWriter::new(); let mut writer = MemWriter::new();
self.response_headers.deref().write_all(&mut writer); self.response_headers.deref().write_all(&mut writer).ok().expect("Writing response headers failed");
ByteString::new(writer.unwrap()) ByteString::new(writer.unwrap())
} }
fn OverrideMimeType(&self, _mime: DOMString) { fn OverrideMimeType(&self, _mime: DOMString) {