Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Chore: Remove unused GetFocusTopLevelBrowsingContext from EmbedderToConstellationMessage (#37716)

Browse source 
This is a legacy message used only by WebDriver to focus the webview,
when session just created. Right now this is just dead_code which is not
detected by Lint.

Testing: No behaviour change.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye 2025-06-26 17:45:59 +08:00 • committed by GitHub
parent 3cda9f2fb2
commit 125df89836
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/constellation/constellation.rs
View file

@ -1277,17 +1277,6 @@ where
EmbedderToConstellationMessage::Exit => { EmbedderToConstellationMessage::Exit => {
self.handle_exit(); self.handle_exit();
}, },
EmbedderToConstellationMessage::GetFocusTopLevelBrowsingContext(resp_chan) => {
let focused_context = self
.webviews
.focused_webview()
.filter(|(_, webview)| {
self.browsing_contexts
.contains_key(&webview.focused_browsing_context_id)
})
.map(|(id, _)| id);
let _ = resp_chan.send(focused_context);
},
// Perform a navigation previously requested by script, if approved by the embedder. // Perform a navigation previously requested by script, if approved by the embedder.
// If there is already a pending page (self.pending_changes), it will not be overridden; // If there is already a pending page (self.pending_changes), it will not be overridden;
// However, if the id is not encompassed by another change, it will be. // However, if the id is not encompassed by another change, it will be.

3
components/constellation/tracing.rs
View file

@ -50,9 +50,6 @@ mod from_compositor {
fn log_target(&self) -> &'static str { fn log_target(&self) -> &'static str {
match self { match self {
Self::Exit => target!("Exit"), Self::Exit => target!("Exit"),
Self::GetFocusTopLevelBrowsingContext(..) => {
target!("GetFocusTopLevelBrowsingContext")
},
Self::IsReadyToSaveImage(..) => target!("IsReadyToSaveImage"), Self::IsReadyToSaveImage(..) => target!("IsReadyToSaveImage"),
Self::AllowNavigationResponse(..) => target!("AllowNavigationResponse"), Self::AllowNavigationResponse(..) => target!("AllowNavigationResponse"),
Self::LoadUrl(..) => target!("LoadUrl"), Self::LoadUrl(..) => target!("LoadUrl"),

3
components/shared/constellation/lib.rs
View file

@ -39,9 +39,6 @@ use webrender_api::units::LayoutVector2D;
pub enum EmbedderToConstellationMessage { pub enum EmbedderToConstellationMessage {
/// Exit the constellation. /// Exit the constellation.
Exit, Exit,
/// Request that the constellation send the current focused top-level browsing context id,
/// over a provided channel.
GetFocusTopLevelBrowsingContext(IpcSender<Option<WebViewId>>),
/// Query the constellation to see if the current compositor output is stable /// Query the constellation to see if the current compositor output is stable
IsReadyToSaveImage(HashMap<PipelineId, Epoch>), IsReadyToSaveImage(HashMap<PipelineId, Epoch>),
/// Whether to allow script to navigate. /// Whether to allow script to navigate.