Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-16 03:43:38 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't explicitly handle dirty roots that are shadow roots (#37862)

Browse source 
Dirty roots are never shadow roots, since we use the flat tree for
invalidation. The flat tree does not contain shadow roots.

Reverts https://github.com/servo/servo/pull/35132. When that patch was
submitted we used the DOM tree for invalidation, so it was possible to
encounter shadow roots.

Testing: Covered by
`shadow-dom/untriaged/events/event-dispatch/test-003.html`

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-07-04 09:11:04 +02:00 • committed by GitHub
parent a6b27c5078
commit 13eeb29878
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/document.rs
View file

@ -663,14 +663,8 @@ impl Document {
has_dirty_descendants &= *ancestor != *new_dirty_root;
}
let maybe_shadow_host = new_dirty_root
.downcast::<ShadowRoot>()
.map(ShadowRootMethods::Host);
let new_dirty_root_element = new_dirty_root
.downcast::<Element>()
.or(maybe_shadow_host.as_deref());
self.dirty_root.set(new_dirty_root_element);
self.dirty_root
.set(Some(new_dirty_root.downcast::<Element>().unwrap()));
}
pub(crate) fn take_dirty_root(&self) -> Option<DomRoot<Element>> {