Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-16 09:58:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Improve sizing for inline SVG (#38603)

Browse source 
The metadata provided by usvg has unreliable sizes. Ignore it, and rely
on the `width`, `height` and `viewBox` attributes instead.

Note that inline SVG with a natural aspect ratio but no natural sizes
should stretch to the containing block. This is left for a follow-up.

Bumps Stylo to https://github.com/servo/stylo/pull/229

Testing: Improves several WPT.

---------

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This commit is contained in:
Oriol Brufau 2025-08-12 05:45:15 -07:00 • committed by GitHub
parent 319f4f0e38
commit 141413d52e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
81 changed files with 156 additions and 260 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/CSS2/floats-clear/float-replaced-width-007.xht.ini vendored
View file

@ -1,2 +0,0 @@
[float-replaced-width-007.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/block-replaced-width-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[block-replaced-width-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-block-replaced-height-009.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-block-replaced-height-009.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-block-replaced-width-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-block-replaced-width-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-block-replaced-width-007.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-block-replaced-width-007.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-block-replaced-width-008.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-block-replaced-width-008.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-replaced-height-009.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-replaced-height-009.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-replaced-width-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-replaced-width-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-replaced-width-008.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-replaced-width-008.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/inline-replaced-width-009.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-replaced-width-009.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-003a.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-003a.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-003b.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-003b.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-003c.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-003c.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-009.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-009.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-023.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-023.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-030.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-030.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-037.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-037.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-051.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-051.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/absolute-replaced-width-065.xht.ini vendored
View file

@ -1,2 +0,0 @@
[absolute-replaced-width-065.xht]
expected: FAIL

2
tests/wpt/meta/css/css-flexbox/flex-aspect-ratio-img-column-018.html.ini vendored
View file

@ -1,2 +0,0 @@
[flex-aspect-ratio-img-column-018.html]
expected: FAIL

2
tests/wpt/meta/css/css-flexbox/flex-aspect-ratio-img-row-015.html.ini vendored
View file

@ -1,2 +0,0 @@
[flex-aspect-ratio-img-row-015.html]
expected: FAIL

6
tests/wpt/meta/css/css-flexbox/svg-root-as-flex-item-006.html.ini vendored
View file

@ -1,6 +0,0 @@
[svg-root-as-flex-item-006.html]
[svg 1]
expected: FAIL
[svg 1: undefined]
expected: FAIL

2
tests/wpt/meta/css/css-overflow/display-flex-svg-overflow-default.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[display-flex-svg-overflow-default.html]
expected: FAIL

6
tests/wpt/meta/css/css-sizing/intrinsic-size-fallback-replaced.html.ini vendored
View file

@ -10,9 +10,3 @@
[.test 8]
expected: FAIL
[.test 3]
expected: FAIL
[.test 7]
expected: FAIL

2
tests/wpt/meta/css/css-sizing/replaced-aspect-ratio-stretch-fit-002.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[replaced-aspect-ratio-stretch-fit-002.html]
expected: FAIL

24
tests/wpt/meta/css/css-sizing/svg-intrinsic-size-001.html.ini vendored
View file

@ -1,30 +1,6 @@
[svg-intrinsic-size-001.html]
[svg 1: undefined]
expected: FAIL
[svg 2: undefined]
expected: FAIL
[svg 3: undefined]
expected: FAIL
[svg 4: undefined]
expected: FAIL
[svg 5: undefined]
expected: FAIL
[svg 1]
expected: FAIL
[svg 2]
expected: FAIL
[svg 3]
expected: FAIL
[svg 4]
expected: FAIL
[svg 5]
expected: FAIL

24
tests/wpt/meta/css/css-sizing/svg-intrinsic-size-002.html.ini vendored
View file

@ -1,30 +1,6 @@
[svg-intrinsic-size-002.html]
[svg 1: undefined]
expected: FAIL
[svg 2: undefined]
expected: FAIL
[svg 3: undefined]
expected: FAIL
[svg 4: undefined]
expected: FAIL
[svg 5: undefined]
expected: FAIL
[svg 1]
expected: FAIL
[svg 2]
expected: FAIL
[svg 3]
expected: FAIL
[svg 4]
expected: FAIL
[svg 5]
expected: FAIL

24
tests/wpt/meta/css/css-sizing/svg-intrinsic-size-003.html.ini vendored
View file

@ -1,30 +1,6 @@
[svg-intrinsic-size-003.html]
[svg 1: undefined]
expected: FAIL
[svg 2: undefined]
expected: FAIL
[svg 3: undefined]
expected: FAIL
[svg 4: undefined]
expected: FAIL
[svg 5: undefined]
expected: FAIL
[svg 1]
expected: FAIL
[svg 2]
expected: FAIL
[svg 3]
expected: FAIL
[svg 4]
expected: FAIL
[svg 5]
expected: FAIL

20
tests/wpt/meta/css/css-sizing/svg-intrinsic-size-004.html.ini vendored
View file

@ -1,24 +1,6 @@
[svg-intrinsic-size-004.html]
[svg 1: undefined]
expected: FAIL
[svg 2: undefined]
expected: FAIL
[svg 3: undefined]
expected: FAIL
[svg 4: undefined]
expected: FAIL
[svg 1]
expected: FAIL
[svg 2]
expected: FAIL
[svg 3]
expected: FAIL
[svg 4]
[svg 5]
expected: FAIL

2
tests/wpt/meta/css/css-sizing/svg-no-ar-max-height-min-content.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-no-ar-max-height-min-content.html]
expected: FAIL

2
tests/wpt/meta/css/css-sizing/svg-no-ar-min-height-min-content.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-no-ar-min-height-min-content.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/css-skew-001.html.ini vendored
View file

@ -1,2 +0,0 @@
[css-skew-001.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/css-skew-002.html.ini vendored
View file

@ -1,2 +0,0 @@
[css-skew-002.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/group/svg-transform-group-011.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-transform-group-011.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/group/svg-transform-nested-021.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-transform-nested-021.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/group/svg-transform-nested-029.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-transform-nested-029.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-036.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-036.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-039.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-039.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-041.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-041.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-042.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-042.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-043.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-043.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-044.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-044.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-045.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-045.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-046.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-046.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-048.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-048.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-058.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-058.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-059.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-059.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-060.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-060.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-061.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-061.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-062.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-062.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-063.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-063.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-064.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-064.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-065.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-065.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-066.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-066.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-067.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-067.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-068.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-068.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/matrix/svg-matrix-069.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-matrix-069.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-001.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-001.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-002.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-002.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-003.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-003.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-004.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-004.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-008.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-008.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-009.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-009.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-010.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-010.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-011.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-011.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-012.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-012.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-013.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-013.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-014.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-014.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-015.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-015.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-016.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-016.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/scale/svg-scale-017.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-scale-017.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/skewX/svg-skewx-with-units.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-skewx-with-units.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/skewY/svg-skewy-with-units.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[svg-skewy-with-units.html]
expected: FAIL

2
tests/wpt/meta/css/css-transforms/translate/svg-translate-with-units.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-translate-with-units.html]
expected: FAIL

4
tests/wpt/meta/css/cssom-view/outer-svg.html.ini vendored
View file

@ -1,7 +1,3 @@
[outer-svg.html]
[scrollWidth, scrollHeight, scrollTop and scrollLeft work on outer svg element]
expected: FAIL
[clientWidth, clientHeight, clientTop and clientLeft work on outer svg element]
expected: FAIL

2
tests/wpt/meta/css/filter-effects/svg-feimage-004.html.ini vendored
View file

@ -1,2 +0,0 @@
[svg-feimage-004.html]
expected: FAIL