Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-09 15:35:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Prevent "scroll to fragment" from scrolling offscreen (#32129)

Browse source 
Previously, the "scroll to fragment" operation could scroll past the end
of the screen, because the scroll position was not clamped to viewport
boundaries. Correct this by using the `Window::scroll()` method which
handles this case.

In addition, ensure that `Window`'s `current_viewport` member is
initialized properly when it is created.
This commit is contained in:
Martin Robinson 2024-04-25 02:12:16 +02:00 • committed by GitHub
parent bef6c295aa
commit 1440406e91
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 60 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/wpt/meta-legacy-layout/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html.ini Normal file
View file

@ -0,0 +1,3 @@
[scroll-position-vertical-lr.html]
[Fragment Navigation: Scroll to block start position in vertical-lr writing mode]
expected: FAIL

7
tests/wpt/meta/MANIFEST.json
View file

@ -621660,6 +621660,13 @@
}
]
],
"scroll-position-inline-nearest.html": [
"4aab0aa5e5a1e4a3eea82282be2344586a9a6d02",
[
null,
{}
]
],
"scroll-position-vertical-lr.html": [
"57d99440e114968e7dcd1b61ebf2d18c7bca987b",
[

3
tests/wpt/meta/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html.ini Normal file
View file

@ -0,0 +1,3 @@
[scroll-position-vertical-lr.html]
[Fragment Navigation: Scroll to block start position in vertical-lr writing mode]
expected: FAIL

30
tests/wpt/tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-inline-nearest.html Normal file
View file

@ -0,0 +1,30 @@
<!DOCTYPE html>
<html style="writing-mode: vertical-lr;">
<head>
<meta charset="UTF-8">
<title>Fragment Navigation: inline start position should not scroll out of content range</title>
<link rel="help" href="https://html.spec.whatwg.org/multipage/#scroll-to-the-fragment-identifier">
<link rel="author" href="mailto:mrobinson@igalia.com" title="Martin Robinson">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
</head>
<body>
<!-- When scrolling to this fragment the viewport inline position should not
change because, it is already fully enclosed by the viewport and page width. -->
<div id="test1" style="position: absolute; top: 5000px; left: 100px; height: 100px; width: 100px;"></div>
<script>
var t = async_test("ScrollToFragment");
t.step(() => {
location.hash = "test1";
setTimeout(t.step_func(() => {
assert_true(window.scrollY > 0);
assert_true(window.scrollY < 5000);
assert_equals(window.scrollX, 0);
t.done();
}));
});
</script>
</body>
</html>