Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Do not glob-export DevtoolsControlMsg variants.

Browse source
This commit is contained in:
Ruud van Asseldonk 2015-02-13 13:15:14 +01:00
parent 66f4faf44f
commit 1452614e28
5 changed files with 15 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/compositing/constellation.rs
View file

@ -7,7 +7,7 @@ use pipeline::{Pipeline, CompositionPipeline};
use compositor_task::CompositorProxy; use compositor_task::CompositorProxy;
use compositor_task::Msg as CompositorMsg; use compositor_task::Msg as CompositorMsg;
use devtools_traits; use devtools_traits;
use devtools_traits::DevtoolsControlChan; use devtools_traits::{DevtoolsControlChan, DevtoolsControlMsg};
use geom::rect::{Rect, TypedRect}; use geom::rect::{Rect, TypedRect};
use geom::scale_factor::ScaleFactor; use geom::scale_factor::ScaleFactor;
use gfx::font_cache_task::FontCacheTask; use gfx::font_cache_task::FontCacheTask;
@ -521,7 +521,7 @@ impl<LTF: LayoutTaskFactory, STF: ScriptTaskFactory> Constellation<LTF, STF> {
self.image_cache_task.exit(); self.image_cache_task.exit();
self.resource_task.send(resource_task::ControlMsg::Exit).unwrap(); self.resource_task.send(resource_task::ControlMsg::Exit).unwrap();
self.devtools_chan.as_ref().map(|chan| { self.devtools_chan.as_ref().map(|chan| {
chan.send(devtools_traits::ServerExitMsg).unwrap(); chan.send(DevtoolsControlMsg::ServerExitMsg).unwrap();
}); });
self.storage_task.send(StorageTaskMsg::Exit).unwrap(); self.storage_task.send(StorageTaskMsg::Exit).unwrap();
self.font_cache_task.exit(); self.font_cache_task.exit();

10
components/devtools/lib.rs
View file

@ -35,8 +35,8 @@ use actors::root::RootActor;
use actors::tab::TabActor; use actors::tab::TabActor;
use protocol::JsonPacketStream; use protocol::JsonPacketStream;
use devtools_traits::{ServerExitMsg, DevtoolsControlMsg, NewGlobal, DevtoolScriptControlMsg}; use devtools_traits::{ConsoleMessage, DevtoolsControlMsg};
use devtools_traits::{DevtoolsPageInfo, SendConsoleMessage, ConsoleMessage}; use devtools_traits::{DevtoolsPageInfo, DevtoolScriptControlMsg};
use msg::constellation_msg::PipelineId; use msg::constellation_msg::PipelineId;
use util::task::spawn_named; use util::task::spawn_named;
@ -231,11 +231,11 @@ fn run_server(receiver: Receiver<DevtoolsControlMsg>, port: u16) {
match acceptor.accept() { match acceptor.accept() {
Err(ref e) if e.kind == TimedOut => { Err(ref e) if e.kind == TimedOut => {
match receiver.try_recv() { match receiver.try_recv() {
Ok(ServerExitMsg) | Err(Disconnected) => break, Ok(DevtoolsControlMsg::ServerExitMsg) | Err(Disconnected) => break,
Ok(NewGlobal(id, sender, pageinfo)) => Ok(DevtoolsControlMsg::NewGlobal(id, sender, pageinfo)) =>
handle_new_global(actors.clone(), id,sender, &mut actor_pipelines, handle_new_global(actors.clone(), id,sender, &mut actor_pipelines,
pageinfo), pageinfo),
Ok(SendConsoleMessage(id, console_message)) => Ok(DevtoolsControlMsg::SendConsoleMessage(id, console_message)) =>
handle_console_message(actors.clone(), id, console_message, handle_console_message(actors.clone(), id, console_message,
&actor_pipelines), &actor_pipelines),
Err(Empty) => acceptor.set_timeout(Some(POLL_TIMEOUT)), Err(Empty) => acceptor.set_timeout(Some(POLL_TIMEOUT)),

1
components/devtools_traits/lib.rs
View file

@ -20,7 +20,6 @@ extern crate "serialize" as rustc_serialize;
extern crate url; extern crate url;
extern crate util; extern crate util;
pub use self::DevtoolsControlMsg::*;
pub use self::DevtoolScriptControlMsg::*; pub use self::DevtoolScriptControlMsg::*;
pub use self::EvaluateJSReply::*; pub use self::EvaluateJSReply::*;

5
components/script/dom/console.rs
View file

@ -7,7 +7,7 @@ use dom::bindings::codegen::Bindings::ConsoleBinding::ConsoleMethods;
use dom::bindings::global::{GlobalRef, GlobalField}; use dom::bindings::global::{GlobalRef, GlobalField};
use dom::bindings::js::{JSRef, Temporary}; use dom::bindings::js::{JSRef, Temporary};
use dom::bindings::utils::{Reflector, reflect_dom_object}; use dom::bindings::utils::{Reflector, reflect_dom_object};
use devtools_traits::{SendConsoleMessage, ConsoleMessage}; use devtools_traits::{DevtoolsControlMsg, ConsoleMessage};
use util::str::DOMString; use util::str::DOMString;
#[dom_struct] #[dom_struct]
@ -68,7 +68,8 @@ fn propagate_console_msg(console: &JSRef<Console>, console_message: ConsoleMessa
GlobalRef::Window(window_ref) => { GlobalRef::Window(window_ref) => {
let pipelineId = window_ref.page().id; let pipelineId = window_ref.page().id;
console.global.root().r().as_window().page().devtools_chan.as_ref().map(|chan| { console.global.root().r().as_window().page().devtools_chan.as_ref().map(|chan| {
chan.send(SendConsoleMessage(pipelineId, console_message.clone())).unwrap(); chan.send(DevtoolsControlMsg::SendConsoleMessage(
pipelineId, console_message.clone())).unwrap();
}); });
}, },

9
components/script/script_task.rs
View file

@ -41,8 +41,8 @@ use page::{Page, IterablePage, Frame};
use timers::TimerId; use timers::TimerId;
use devtools; use devtools;
use devtools_traits::{DevtoolsControlChan, DevtoolsControlPort, NewGlobal, GetRootNode, DevtoolsPageInfo}; use devtools_traits::{DevtoolsControlChan, DevtoolsControlPort, GetRootNode, DevtoolsPageInfo};
use devtools_traits::{DevtoolScriptControlMsg, EvaluateJS, GetDocumentElement}; use devtools_traits::{DevtoolsControlMsg, DevtoolScriptControlMsg, EvaluateJS, GetDocumentElement};
use devtools_traits::{GetChildren, GetLayout, ModifyAttribute, WantsLiveNotifications}; use devtools_traits::{GetChildren, GetLayout, ModifyAttribute, WantsLiveNotifications};
use script_traits::CompositorEvent; use script_traits::CompositorEvent;
use script_traits::CompositorEvent::{ResizeEvent, ReflowEvent, ClickEvent}; use script_traits::CompositorEvent::{ResizeEvent, ReflowEvent, ClickEvent};
@ -947,8 +947,9 @@ impl ScriptTask {
title: document.r().Title(), title: document.r().Title(),
url: final_url url: final_url
}; };
chan.send(NewGlobal(pipeline_id, self.devtools_sender.clone(), chan.send(DevtoolsControlMsg::NewGlobal(pipeline_id,
page_info)).unwrap(); self.devtools_sender.clone(),
page_info)).unwrap();
} }
} }
} }