Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Address review comments

Browse source
This commit is contained in:
Manish Goregaokar 2014-10-08 03:18:45 +05:30
parent 3a1f9bd7fb
commit 1484acb7af
9 changed files with 38 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/script/dom/macros.rs
View file

@ -59,21 +59,10 @@ macro_rules! make_url_getter(
fn $attr(self) -> DOMString {
use dom::element::{Element, AttributeHandlers};
use dom::bindings::codegen::InheritTypes::ElementCast;
use dom::document::DocumentHelpers;
use dom::node::document_from_node;
use url::UrlParser;
#[allow(unused_imports)]
use std::ascii::StrAsciiExt;
let elem: JSRef<Element> = ElementCast::from_ref(self);
let action = elem.get_string_attribute($htmlname);
let doc = document_from_node(self).root();
let base = doc.url();
// https://html.spec.whatwg.org/multipage/infrastructure.html#reflect
// XXXManishearth this doesn't handle `javascript:` urls properly
match UrlParser::new().base_url(base).parse(action.as_slice()) {
Ok(parsed) => parsed.serialize(),
Err(_) => base.serialize()
}
let element: JSRef<Element> = ElementCast::from_ref(self);
element.get_url_attribute($htmlname)
}
);
($attr:ident) => {